This repository was archived by the owner on Jul 3, 2024. It is now read-only.
Add compatibility for Rails 7.1 and HAML 6 #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makmic
changed the title
makmic
force-pushed
the
ml/add-rails-7-1-support
branch
from
8ee1278 to
1316a4b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue reported breaking compatibility with Rails 7.1 #12
Rails 7.1 turned out to
#prependto patch#unwrapped_html_escape. We solved that by prepending our own patch toERB::Utiland its singleton classActionView::OutputBufferandhtml_escape_onceas well (the latter was an oversight for the current version of AngularXSS as well)HAML 6 is now also different, but easier to patch. It ditched its own escaping in 6.0 on all places except
Haml::Util.escape_html. Another module prepend on our side fixes that.I suggest bumping the Version of this gem to 1.0 after these changes are merged into master.