Draft
Conversation
Member
|
Yes, there should be a smoke-test as well – I'd just create one for each of the 3 project types (minimal, standard, full – see existing GitHub Actions config), build the image for a freshly generated project and validate the app starts up in the container |
Comment on lines
+42
to
+49
| ENV RUST_BACKTRACE=1 | ||
| # We don't want `anyhow` to capture backtraces for | ||
| # "routine" errors. Just panics. | ||
| ENV RUST_LIB_BACKTRACE=0 | ||
|
|
||
| ENV APP_ENVIRONMENT=production | ||
| ENV APP_SERVER__PORT=3000 | ||
| ENV APP_SERVER__IP="0.0.0.0" |
Collaborator
There was a problem hiding this comment.
These ENVs ideally aren't defined here.
APP_SERVER ones especiialy, they should be set by the config crate directly
Contributor
Author
There was a problem hiding this comment.
Yeah, we actually have an open issue for that on restations too. Do you feel it's a must for this PR, or can it be done in a separate one?
marcoow
force-pushed
the
main
branch
10 times, most recently
from
2ba0a72 to
436bdf9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a Dockerfile template based on the one we're using on mainmatter/restations, and updates the README.
@marcoow would it make sense to have a smoke test at the Gerust level? And perhaps a smoke test template as well for the blueprint, so the generated app would have it baked in (perhaps with the step commented out in the CI workflow)?
I'd add a health check endpoint so we can hit it from the smoke test.
Closes #216