Skip to content

Catch utf8 decoding errors explicitly to fix py310 test failure #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
magicmark wants to merge 1 commit into
base: add_http_multipart_transport
Choose a base branch
from
Open

Catch utf8 decoding errors explicitly to fix py310 test failure #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions gql/transport/http_multipart_transport.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,10 +303,11 @@ async def _parse_multipart_part(
errors=payload.get("errors"),
extensions=payload.get("extensions"),
)
except UnicodeDecodeError as e:
log.warning(f"Skipping part - failed to decode as UTF-8: {e}")
return None
except json.JSONDecodeError as e:
log.warning(
f"Failed to parse JSON: {e}, body: {body[:100] if body else ''}"
)
log.warning(f"Skipping part - failed to parse JSON: {e}")
return None

async def execute(
Expand Down