magento/magento2#39948: Magento_Persistent performance overhead on non-cart, non-checkout pages

[KrasnoshchokBohdan]

• new QuoteResourceWrapper class that uses direct SQL queries instead of loading the entire quote object, which should improve performance

Description (*)

I decided to test the solution proposed by the author. It turned out that the changes reduced the execution time of CheckExpirePersistentQuoteObserver from ~52ms to less than 1ms.
Before

After

So I make this pull request to initiate further discussion.

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes Magento_Persistent performance overhead on non-cart, non-checkout pages #39948

Manual testing scenarios (*)

1. Add product to cart (for example from PLP)
2. Enter PDP with profiler enabled

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @KrasnoshchokBohdan. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[KrasnoshchokBohdan]

@magento run all tests

[KrasnoshchokBohdan]

@magento run all tests

[KrasnoshchokBohdan]

@magento run Static Tests

[KrasnoshchokBohdan]

@magento run Database Compare, Functional Tests B2B, Functional Tests CE, Functional Tests EE, Integration Tests, Magento Health Index, Sample Data Tests B2B, Sample Data Tests CE, Sample Data Tests EE, Semantic Version Checker, Unit Tests, WebAPI Tests

[Copilot]

Pull Request Overview

This PR introduces a new QuoteResourceWrapper to optimize persistent quote checks via direct SQL queries and updates the CheckExpirePersistentQuoteObserver (and its tests) to use it instead of loading full quote models.

• Add QuoteResourceWrapper with isActive and isPersistent methods
• Refactor CheckExpirePersistentQuoteObserver to use the new wrapper and remove model loading
• Update unit tests to cover both the observer and the wrapper

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
app/code/Magento/Persistent/Model/QuoteResourceWrapper.php	New resource wrapper for efficient SQL-based quote queries
app/code/Magento/Persistent/Observer/CheckExpirePersistentQuoteObserver.php	Refactor observer to use QuoteResourceWrapper
app/code/Magento/Persistent/Test/Unit/Model/QuoteResourceWrapperTest.php	Unit tests for QuoteResourceWrapper
app/code/Magento/Persistent/Test/Unit/Observer/CheckExpirePersistentQuoteObserverTest.php	Updated observer tests to mock the new wrapper

Comments suppressed due to low confidence (5)

app/code/Magento/Persistent/Observer/CheckExpirePersistentQuoteObserver.php:77

• [nitpick] Matching the checkout page by the raw string 'checkout' may unintentionally match other URLs. Consider using a more precise route or configuration-based constant for clarity and robustness.

    private $checkoutPagePath = 'checkout';

app/code/Magento/Persistent/Observer/CheckExpirePersistentQuoteObserver.php:25

• [nitpick] Property naming is inconsistent: some fields use underscore prefixes (e.g., $_customerSession) while others (e.g., $request) use camelCase without prefixes. Standardize on a single naming convention to improve readability.

    protected $_customerSession;

app/code/Magento/Persistent/Observer/CheckExpirePersistentQuoteObserver.php:3

• The copyright year 2015 appears outdated compared to other files (which use 2025). Please update it for consistency.

* Copyright 2015 Adobe

app/code/Magento/Persistent/Test/Unit/Model/QuoteResourceWrapperTest.php:204

• [nitpick] In testIsPersistentTypeCasting, consider adding a with('quote') expectation on getTableName to ensure the correct table is used in the query.

$this->resourceConnectionMock->expects($this->once())->method('getTableName')->willReturn($tableName);

app/code/Magento/Persistent/Test/Unit/Observer/CheckExpirePersistentQuoteObserverTest.php:123

• [nitpick] The test uses an integer 10 for the quote ID. Ensure consistent use of integer IDs across all tests to avoid potential type mismatches.

$quoteId = 10;

[Copilot]

Direct use of ObjectManager is discouraged. Consider injecting QuoteResourceWrapper via constructor dependency injection (with a default null and fallback) to improve testability and adhere to best practices.

Suggested change

	$this->quoteResourceWrapper = $quoteResourceWrapper ?: ObjectManager::getInstance()
	->get(QuoteResourceWrapper::class);
	$this->quoteResourceWrapper = $quoteResourceWrapper;