Skip to content

fix: parent product cache not clearing #37528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adamzero1 wants to merge 3 commits into
base: 2.4-develop
Choose a base branch
from
Open

fix: parent product cache not clearing #37528

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2edf7c5
fix: parent product cache not clearing
adamzero1 May 23, 2023
ac815b5
Merge branch '2.4-develop' into parent-product-cache
engcom-Hotel May 26, 2023
c39e617
Merge branch '2.4-develop' into parent-product-cache
engcom-Hotel May 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions app/code/Magento/CatalogInventory/Model/Indexer/Stock/CacheCleaner.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ private function getProductStockStatuses(array $productIds)

$statuses = [];
foreach ($this->getConnection()->fetchAll($select) as $item) {
$statuses[$item['product_id']] = $item;
$statuses[$item['product_id'].($item['parent_id']? '-'.$item['parent_id']: '')] = $item;
}
return $statuses;
}
Expand All @@ -142,27 +142,29 @@ private function getProductStockStatuses(array $productIds)
*/
private function getProductIdsForCacheClean(array $productStatusesBefore, array $productStatusesAfter)
{
$disabledProductsIds = array_diff(array_keys($productStatusesBefore), array_keys($productStatusesAfter));
$enabledProductsIds = array_diff(array_keys($productStatusesAfter), array_keys($productStatusesBefore));
$commonProductsIds = array_intersect(array_keys($productStatusesBefore), array_keys($productStatusesAfter));
$beforeProductIds = array_unique(array_column($productStatusesBefore, 'product_id'));
$afterProductIds = array_unique(array_column($productStatusesAfter, 'product_id'));
$disabledProductsIds = array_diff($beforeProductIds, $afterProductIds);
$enabledProductsIds = array_diff($afterProductIds, $beforeProductIds);
$commonRelations = array_intersect(array_keys($productStatusesBefore), array_keys($productStatusesAfter));
$productIds = array_merge($disabledProductsIds, $enabledProductsIds);

$stockThresholdQty = $this->stockConfiguration->getStockThresholdQty();

foreach ($commonProductsIds as $productId) {
$statusBefore = $productStatusesBefore[$productId];
$statusAfter = $productStatusesAfter[$productId];
foreach ($commonRelations as $commonRelationId) {
$statusBefore = $productStatusesBefore[$commonRelationId];
$statusAfter = $productStatusesAfter[$commonRelationId];

if ($statusBefore['stock_status'] !== $statusAfter['stock_status']
|| ($stockThresholdQty && $statusAfter['qty'] <= $stockThresholdQty)) {
$productIds[] = $productId;
$productIds[] = $statusAfter['product_id'];
if (isset($statusAfter['parent_id'])) {
$productIds[] = $statusAfter['parent_id'];
}
}
}

return array_map('intval', $productIds);
return array_unique($productIds);
}

/**
Expand Down