Skip to content

Magento_TaxImportExport: avoid using deprecated escape* methods from … #31713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Magento_TaxImportExport: avoid using deprecated escape* methods from … #31713

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions app/code/Magento/TaxImportExport/view/adminhtml/templates/importExport.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,10 @@
* See COPYING.txt for license details.
*/

/** @var $block \Magento\TaxImportExport\Block\Adminhtml\Rate\ImportExport */
/**
* @var $block \Magento\TaxImportExport\Block\Adminhtml\Rate\ImportExport
* @var \Magento\Framework\Escaper $escaper
*/
/** @var \Magento\Framework\View\Helper\SecureHtmlRenderer $secureRenderer */
?>
<div class="import-export-tax-rates">
Expand All @@ -13,14 +16,14 @@
<?php if ($block->getUseContainer()):?>
<form id="import-form"
class="admin__fieldset"
action="<?= $block->escapeUrl($block->getUrl('tax/rate/importPost')) ?>"
action="<?= $escaper->escapeUrl($block->getUrl('tax/rate/importPost')) ?>"
method="post"
enctype="multipart/form-data">
<?php endif; ?>
<?= $block->getBlockHtml('formkey') ?>
<div class="fieldset admin__field">
<label for="import_rates_file" class="admin__field-label">
<span><?= $block->escapeHtml(__('Import Tax Rates')) ?></span>
<span><?= $escaper->escapeHtml(__('Import Tax Rates')) ?></span>
</label>
<div class="admin__field-control">
<input type="file"
Expand Down Expand Up @@ -66,13 +69,13 @@ script;
<?php if ($block->getUseContainer()):?>
<form id="export_form"
class="admin__fieldset"
action="<?= $block->escapeUrl($block->getUrl('tax/rate/exportPost')) ?>"
action="<?= $escaper->escapeUrl($block->getUrl('tax/rate/exportPost')) ?>"
method="post"
enctype="multipart/form-data">
<?php endif; ?>
<?= $block->getBlockHtml('formkey') ?>
<div class="fieldset admin__field">
<span class="admin__field-label"><span><?= $block->escapeHtml(__('Export Tax Rates')) ?></span></span>
<span class="admin__field-label"><span><?= $escaper->escapeHtml(__('Export Tax Rates')) ?></span></span>
<div class="admin__field-control">
<?= $block->getButtonHtml(__('Export Tax Rates'), "export_form.submit()") ?>
</div>
Expand Down