-
Notifications
You must be signed in to change notification settings - Fork 9.4k
issue 265: moved catalog store front tests to magento #29785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2.4-develop
Are you sure you want to change the base?
issue 265: moved catalog store front tests to magento #29785
Conversation
Merge 2.4-develop to develop-storefront
MC-36959 Remove "compareArraysRecursively" logic duplication
Hi @ledian-hymetllari. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento run all tests |
@magento run all tests |
@magento run all tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge 2.4-develop and rerun tests
app/code/Magento/CatalogImportExport/Test/Integration/_files/overrides.xml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please compare deliver changes for following tests classes (compare tests with catalog-storefront/catalog-storefront-with-overrides branch):
-
dev/tests/api-functional/testsuite/Magento/GraphQl/Catalog/ProductSearchPriceFilterTest.php
Some dataset fields missing -
dev/tests/api-functional/testsuite/Magento/GraphQl/ConfigurableProduct/ConfigurableProductMultipleStoreViewTest.php
New test (\Magento\GraphQl\ConfigurableProduct\ConfigurableProductMultipleStoreViewTest::testConfigurableProductVariationAssignedToDifferentWebsites) missing
@magento run all tests |
@ledian-hymetllari regarding to your comment : PLEASE IGNORE this is catalog-storefront PR |
PLEASE IGNORE this is catalog-storefront PR
Description (*)
This is related to catalog store front issue: magento/catalog-storefront#265
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)