Bulk ACL management for AsynchronousOperations Admin UI #27580

nuzil · 2020-04-04T14:29:53Z

Description (*)

After Migrating of Asynchronous Operations from Magento Commerce to Magento Open Source, looks like part of functionality was extended.

In details:
In magento_bulk table was added user_type, which defines type of the user who created Bulk Operation.

Possible types are:

Admin
Integration
Guest
Customer

In current implementation all Admin UI components have no idea about user type:

https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/AsynchronousOperations/view/adminhtml/ui_component/bulk_listing.xml - in default Grid there are NO DataSource is defined, so Admin see the whole operations, but at the same time, he cannot see Details of those operations:

https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/AsynchronousOperations/Controller/Adminhtml/Bulk/Details.php#L52

But at you can see from implementation,
https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/AsynchronousOperations/Model/AccessValidator.php#L58

that permissions are checked based on UserID and fully ignoring UserType. Which means, that Admin has access to All transactions or all user types with the same ID.

Fixed Issues (if relevant)

Current implementation will add:

New ACL roles for give possibilities for Admin define permissions for Admin/Integration user to have access only to specific user types operations.
With restricted user role, Admin will be able to see only operations that are assigned to him, View detailes or Restart them
Also Admin notifications will be restricted only to allowed.

Questions or comments

Auto tests still in process, but main implementation can be already reviewed.

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

Resolved issues:

resolves [Issue] Bulk ACL management for AsynchronousOperations Admin UI #29757: Bulk ACL management for AsynchronousOperations Admin UI

m2-assistant · 2020-04-04T14:29:55Z

Hi @nuzil. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

sidolov · 2020-08-26T15:19:27Z

@magento create issue

sidolov · 2020-08-27T18:09:45Z

lib/internal/Magento/Framework/Bulk/BulkStatusInterface.php

+     * @return BulkSummaryInterface[]
+     * @since 100.2.0
+     */
+    public function getBulksByUserAndType($userId, $userTypeId);


Adding the new methods to the interface is backward-incompatible change. Please, introduce new interface with this method.

sidolov · 2020-08-27T18:19:30Z

app/code/Magento/AsynchronousOperations/Model/BulkStatus.php

+    /**
+     * @inheritDoc
+     */
+    public function getBulksByUserAndType($userId, $userTypeId)


Should be extracted to the separate class

sidolov · 2020-08-27T18:19:57Z

app/code/Magento/AsynchronousOperations/Model/BulkOperationsStatus.php

+    /**
+     * @inheritDoc
+     */
+    public function getBulksByUserAndType($userId, $userTypeId)


Should be extracted to separate class

sidolov · 2020-08-27T18:20:28Z

app/code/Magento/AsynchronousOperations/Model/AccessManager.php

+ */
+class AccessManager
+{
+    public const BULK_LOGGING_ACL_GUESTS


Is it possible to make constants private?

sidolov · 2020-08-27T18:21:39Z

app/code/Magento/AsynchronousOperations/Model/AccessManager.php

+     * @param int $bulkUuid
+     * @return bool
+     */
+    public function isAllowedForBulkUuid($bulkUuid)


I prefer to split this class into three with one method.

engcom-Charlie · 2020-09-17T08:03:19Z

@nuzil can you please look at the requested changes?
Thank you.

engcom-Charlie · 2020-09-21T08:24:18Z

Hi @nuzil, I'm closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for your collaboration.

m2-assistant · 2020-09-21T08:24:20Z

Hi @nuzil, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

nuzil · 2020-09-21T08:42:53Z

Hi @engcom-Charlie
I'm on it. As you can see I sync up branches only 4 days ago. Its require some time to refactor so many stuff.

m2-assistant · 2020-09-21T08:42:57Z

Hi @nuzil. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

gabrieldagama

Moving the PR to the correct state, as @nuzil mentioned, it is being worked on.

engcom-Charlie · 2020-10-16T11:53:10Z

Hi, @nuzil will you continue on this PR?
Thank you.

engcom-Charlie · 2020-10-30T08:59:11Z

Hi @nuzil, I'm closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for your collaboration.

m2-assistant · 2020-10-30T08:59:13Z

Hi @nuzil, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

engcom-Charlie · 2020-12-02T12:05:16Z

Closed as duplicate #30806.

m2-assistant · 2020-12-02T12:05:19Z

Hi @nuzil, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

nuzil added 3 commits March 27, 2020 11:30

Start implementing of correct Auth rules

fd5e0e5

Implement of custom ACL and filtering by User Type in Bulk Operations UI

f59fcbb

Manage tests

2febfb7

ghost added the Progress: pending review label Apr 4, 2020

magento-engcom-team added Area: Frontend Component: AsynchronousOperations Component: Bulk Release Line: 2.4 Partner: Comwrap partners-contribution Pull Request is created by Magento Partner Event: Global-Contribution-Day labels Apr 4, 2020

nuzil added 5 commits April 8, 2020 11:20

Fix static tests

2f4ef9f

Fix Static tests

7d50e39

Fix Static Test

dd34542

Iliminate Magento_Logging dependency

1d08280

Fix tests

552f1e7

sidolov added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Aug 17, 2020

sidolov self-assigned this Aug 26, 2020

m2-assistant bot mentioned this pull request Aug 26, 2020

[Issue] Bulk ACL management for AsynchronousOperations Admin UI #29757

Open

4 tasks

ghost added Progress: review and removed Progress: pending review labels Aug 26, 2020

sidolov requested changes Aug 27, 2020

View reviewed changes

ghost added Progress: needs update and removed Progress: review labels Aug 27, 2020

engcom-Charlie self-assigned this Sep 15, 2020

Merge branch '2.4-develop' into bulk-auth

9426193

engcom-Charlie closed this Sep 21, 2020

nuzil reopened this Sep 21, 2020

ghost added Progress: pending review and removed Progress: needs update labels Sep 21, 2020

ghost unassigned sidolov and engcom-Charlie Sep 21, 2020

gabrieldagama suggested changes Sep 21, 2020

View reviewed changes

ghost assigned gabrieldagama Sep 21, 2020

ghost added Progress: needs update and removed Progress: pending review labels Sep 21, 2020

engcom-Charlie self-assigned this Oct 16, 2020

engcom-Charlie closed this Oct 30, 2020

ghost removed the Progress: needs update label Oct 30, 2020

engcom-Charlie reopened this Oct 30, 2020

ghost added the Progress: needs update label Oct 30, 2020

engcom-Charlie mentioned this pull request Nov 9, 2020

Bulk ACL Admin Ui #30806

Open

4 tasks

engcom-Charlie closed this Dec 2, 2020

m2-community-project bot removed the Progress: needs update label Dec 2, 2020

Bulk ACL management for AsynchronousOperations Admin UI #27580

Bulk ACL management for AsynchronousOperations Admin UI #27580

Uh oh!

Conversation

nuzil commented Apr 4, 2020 • edited by m2-assistant bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Fixed Issues (if relevant)

Questions or comments

Contribution checklist (*)

Resolved issues:

Uh oh!

m2-assistant bot commented Apr 4, 2020

Uh oh!

sidolov commented Aug 26, 2020

Uh oh!

sidolov Aug 27, 2020

Choose a reason for hiding this comment

Uh oh!

sidolov Aug 27, 2020

Choose a reason for hiding this comment

Uh oh!

sidolov Aug 27, 2020

Choose a reason for hiding this comment

Uh oh!

sidolov Aug 27, 2020

Choose a reason for hiding this comment

Uh oh!

sidolov Aug 27, 2020

Choose a reason for hiding this comment

Uh oh!

engcom-Charlie commented Sep 17, 2020

Uh oh!

engcom-Charlie commented Sep 21, 2020

Uh oh!

m2-assistant bot commented Sep 21, 2020

Uh oh!

nuzil commented Sep 21, 2020

Uh oh!

m2-assistant bot commented Sep 21, 2020

Uh oh!

gabrieldagama left a comment

Choose a reason for hiding this comment

Uh oh!

engcom-Charlie commented Oct 16, 2020

Uh oh!

engcom-Charlie commented Oct 30, 2020

Uh oh!

m2-assistant bot commented Oct 30, 2020

Uh oh!

engcom-Charlie commented Dec 2, 2020

Uh oh!

m2-assistant bot commented Dec 2, 2020

Uh oh!

Uh oh!

nuzil commented Apr 4, 2020 •

edited by m2-assistant bot

Loading