magento/magento2#8171: Price not saved when creating product via REST API

[Jarzebowsky]

Description (*)

The change covers adding a default typeId set to simple for new products created if no other is sent in post request.

Related Pull Requests

https://github.com/magento/partners-magento2ee/pull/345
https://github.com/magento/partners-magento2b2b/pull/349

Fixed Issues (if relevant)

1. magento/magento2#8171: Price not saved when creating product via REST API
2. Fixes 2.4 : When saving a product using the product repository, the price is not saved #13639
3. Fixes Price not saved when creating product via REST API #30487

Manual testing scenarios (*)

1. Do a POST request to /products with a minimum payload to create a product.

{
"product": {
"sku": "test",
"name": "test",
"price": 12.5,
"attribute_set_id": 4
}
}

2. Created product should have visible and set price.

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

Resolved issues:

1. resolves [Issue] magento/magento2#8171: Price not saved when creating product via REST API #29504: magento/magento2#8171: Price not saved when creating product via REST API

[m2-assistant]

Hi @Jarzebowsky. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[miguelbalparda]

Hi @Jarzebowsky I just realized I can't process this PR because you haven't signed the CLA, you mind doing it so we can move forward? Thanks!

[Jarzebowsky]

Hi @miguelbalparda I'm not able to get into license page as I saw you were doing some changes there. Could you please provide steps to make it go thru? :)

[m2-assistant]

Hi @Jarzebowsky, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[sidolov]

@Jarzebowsky please, use Adobe CLA Signed? to sign the agreement.

[m2-assistant]

Hi @Jarzebowsky, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[novikor]

Hi, @Jarzebowsky ! Thank you for your contribution.
Please fix the static tests

[engcom-Foxtrot]

@magento run all tests

[engcom-Foxtrot]

Performance tests are failing here. Looks like API is failing. @Jarzebowsky could you please check if these API endpoints are working after your fix?

2020/02/25 16:01:04 ERROR - jmeter.protocol.http.sampler.HTTPJavaImpl: readResponse: java.io.IOException: Server returned HTTP response code: 400 for URL: http://localhost/builds/rest/default/V1/products 
2020/02/25 16:01:04 ERROR - jmeter.protocol.http.sampler.HTTPJavaImpl: Cause: java.io.IOException: Server returned HTTP response code: 400 for URL: http://localhost/builds/rest/default/V1/products 
2020/02/25 16:01:04 INFO  - jmeter.protocol.http.sampler.HTTPJavaImpl: Error Response Code: 400 

2020/02/25 16:01:04 ERROR - jmeter.protocol.http.sampler.HTTPJavaImpl: readResponse: java.io.IOException: Server returned HTTP response code: 500 for URL: http://localhost/builds/rest/default/V1/products//stockItems/ 
2020/02/25 16:01:04 ERROR - jmeter.protocol.http.sampler.HTTPJavaImpl: Cause: java.io.IOException: Server returned HTTP response code: 500 for URL: http://localhost/builds/rest/default/V1/products//stockItems/ 
2020/02/25 16:01:04 INFO  - jmeter.protocol.http.sampler.HTTPJavaImpl: Error Response Code: 500 

2020/02/25 16:01:04 ERROR - jmeter.protocol.http.sampler.HTTPJavaImpl: readResponse: java.io.IOException: Server returned HTTP response code: 400 for URL: http://localhost/builds/rest/default/V1/products/ 
2020/02/25 16:01:04 ERROR - jmeter.protocol.http.sampler.HTTPJavaImpl: Cause: java.io.IOException: Server returned HTTP response code: 400 for URL: http://localhost/builds/rest/default/V1/products/ 
2020/02/25 16:01:04 INFO  - jmeter.protocol.http.sampler.HTTPJavaImpl: Error Response Code: 400 

PAT failures should be fixed by 25c37b5

[engcom-Foxtrot]

@magento run all tests

[gabrieldagama]

This PR changes the behavior of an API, previously products were created on payloads without price, now they will fail. Since this is BIC we will aim to deliver this on 2.5.

[gabrieldagama]

@magento run all tests

[gabrieldagama]

@magento run all tests

[gabrieldagama]

@magento run all tests

[gabrieldagama]

@magento run all tests