Don't use void return value from method calls. Fixes errors phpstan f…

…ound while scanning on level 0.
magento · Dec 31, 2024 · e0dc58b · e0dc58b
1 parent 4bca5df
commit e0dc58b
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/app/code/Magento/Downloadable/Model/Product/TypeHandler/Link.php b/app/code/Magento/Downloadable/Model/Product/TypeHandler/Link.php
@@ -81,7 +81,8 @@ public function save(Product $product, array $data)
     protected function clear()
     {
         $this->sampleItem = [];
-        return parent::clear();
+
+        parent::clear();
     }
 
     /**

diff --git a/app/code/Magento/Eav/Model/ResourceModel/Entity/Attribute/Group.php b/app/code/Magento/Eav/Model/ResourceModel/Entity/Attribute/Group.php
@@ -161,7 +161,7 @@ public function updateDefaultGroup($attributeSetId)
     protected function saveNewObject(AbstractModel $object)
     {
         try {
-            return parent::saveNewObject($object);
+            parent::saveNewObject($object);
         } catch (DuplicateException $e) {
             throw new AttributeGroupAlreadyExistsException(
                 __(
@@ -178,7 +178,7 @@ protected function saveNewObject(AbstractModel $object)
     protected function updateObject(AbstractModel $object)
     {
         try {
-            return parent::updateObject($object);
+            parent::updateObject($object);
         } catch (DuplicateException $e) {
             throw new AttributeGroupAlreadyExistsException(
                 __(

diff --git a/app/code/Magento/Store/Block/Store/Switcher.php b/app/code/Magento/Store/Block/Store/Switcher.php
@@ -67,7 +67,8 @@ protected function _construct()
         $this->_loadData();
         $this->setStores([]);
         $this->setLanguages([]);
-        return parent::_construct();
+
+        parent::_construct();
     }
 
     /**

diff --git a/lib/internal/Magento/Framework/HTTP/Client/Socket.php b/lib/internal/Magento/Framework/HTTP/Client/Socket.php
@@ -419,8 +419,7 @@ protected function processResponse()
 
         $line = explode(" ", $responseLine, 3);
         if (count($line) != 3) {
-            // phpstan:ignore "Result of method Magento\Framework\HTTP\Client\Socket::doError() (void) is used."
-            return $this->doError("Invalid response line returned from server: " . $responseLine);
+            $this->doError("Invalid response line returned from server: " . $responseLine);
         }
         $this->_responseStatus = (int)$line[1];
         $this->processResponseHeaders();
@@ -466,8 +465,7 @@ protected function makeRequest($method, $uri, $params = [])
         $errno = $errstr = '';
         $this->_sock = @fsockopen($this->_host, $this->_port, $errno, $errstr, $this->_timeout);
         if (!$this->_sock) {
-            // phpstan:ignore "Result of method Magento\Framework\HTTP\Client\Socket::doError() (void) is used."
-            return $this->doError(sprintf("[errno: %d] %s", $errno, $errstr));
+            $this->doError(sprintf("[errno: %d] %s", $errno, $errstr));
         }
 
         $crlf = "\r\n";