1263: Added UI tests for MarkDirectoryAsMagentoContentRoot #2509
+29,769
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a null project check in `MarkDirectoryAsMagentoContentRoot` to prevent potential NPEs. Replaced `ServiceManager` with the modern `project.getService` for retrieving `Settings` instances. Additionally, updated workflows to run tests via a script and introduced new test fixtures for UI testing.
…-source-directory-for-modules-local-composer-development-using-content-root-feature-tests
…ond-code-source-directory-for-modules-local-composer-development-using-content-root-feature-tests' into 1263-Possibility-to-add-second-code-source-directory-for-modules-local-composer-development-using-content-root-feature-tests
Updated workflows, build configuration, and documentation to target JDK 17 instead of JDK 21. This ensures compatibility with environments and tools requiring JDK 17 while maintaining a consistent development setup.
This ensures that video artifacts from the latest failed test are captured and uploaded for better debugging. The workflow now handles artifact management by copying the video files and uploading them automatically during test failures.
Restrict artifact uploads to Ubuntu runners on failure and update to `upload-artifact@v4`. Additionally, enable the `overwrite` option to ensure the latest video is consistently stored.
Restrict video artifact uploads to Ubuntu runners on failure and change the file extension from `.mp4` to `.avi`. This ensures better alignment with the expected platform outputs and maintains consistency in artifact storage.
Replaced individual file handling with tarball compression for test video artifacts. This streamlines the process and reduces complexity in managing files during failures on Ubuntu runners. Updated the upload path to reflect the new tarball format.
Replaced `gradle` with `./gradlew` in the Linux workflow to ensure the correct Gradle wrapper is used consistently. This change aligns with best practices and improves compatibility across environments.
Change Xvfb screen depth to 24-bit for better compatibility and added a delay to ensure proper initialization. Updated test execution step to set DISPLAY environment variable on Ubuntu.
This change introduces a step to switch back to PhpStorm IDE if the Firefox overlay is detected during test execution. It uses a JavaScript snippet with Robot actions to simulate the ALT+TAB keypress sequence. This ensures seamless continuation of test cases in multi-window environments.
Updated AWT robot script with improved error handling and logging in test cases. Modified GitHub Actions workflow to run tests differently based on OS, ensuring better compatibility with Ubuntu.
Removed unnecessary active window checks for Firefox in the test code. This simplifies the logic and improves reliability by avoiding environment-specific conditions. Retained the core functionality for simulating key presses.
Replaced inline JavaScript workaround with a dedicated `closeBrowser` function to handle browser shutdown across different operating systems. This improves code readability and maintainability while ensuring compatibility with Windows, macOS, and Linux environments.
Removed redundant commands and streamlined the process for killing browser processes across different operating systems. This change reduces unnecessary overhead and ensures a more consistent cleanup approach.
A 5-second delay was introduced to ensure proper loading of the UI before the enable support link is clicked during the test. This helps prevent timing issues and improves test stability.
Replaced browser kill command to target Edge instead of Firefox for Windows. Adjusted GitHub Actions workflow to upload test artifacts on failure specifically for Windows environments.
The test now checks if it's running in the GitHub Actions environment before executing the trial activation workaround. Additionally, a new step was added to handle a "Don't show again" prompt during project setup. This ensures smoother test execution across environments.
Added a fallback scenario to handle an alternative dialog in tests. Updated XPath selectors to reflect changes in the UI structure for better stability.
Updated project setup to use user home directory for temporary files. Introduced a utility method to verify if the project view is visible, improving reliability. Adjusted error handling to ensure tests proceed even when some UI elements are missing.
Changed the test to use `absolutePath` instead of `path` for the temporary project directory. This ensures compatibility and correctness when setting up the test environment.
Replaced 'legacyTests' with 'test' in GitHub workflows for automation consistency. Removed the 'legacyTests' task from the Gradle configuration and adjusted test settings to exclude user interface tests directly in the main 'test' task. This simplifies the build process and reduces redundancy.
Simplified imports, added Javadoc comments, adjusted annotations, and improved variable usage for clarity and maintainability. Minor structural changes include adding final and transient where applicable and enhancing formatting consistency.
…ond-code-source-directory-for-modules-local-composer-development-using-content-root-feature-tests' into 1263-Possibility-to-add-second-code-source-directory-for-modules-local-composer-development-using-content-root-feature-tests
Added a Javadoc comment explaining the purpose of the MarkDirectoryAsMagentoContentRot class. This provides clarity on its role in marking a selected directory as a Magento content root.
Improve code readability by adjusting method signatures for better formatting and consistency. Reorder certain variable declarations to align with logical execution flow. Add `@SuppressWarnings` annotation in `Settings.java` to suppress PMD warnings about excessive public count.
Added missing copyright headers to multiple test files for legal compliance. Also corrected a spelling error in the variable name "initializaed" to "initialized" in the StepsLogger file.
VitaliyBoyko
approved these changes
Mar 29, 2025
VitaliyBoyko
deleted the
1263-Possibility-to-add-second-code-source-directory-for-modules-local-composer-development-using-content-root-feature-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a null project check in
MarkDirectoryAsMagentoContentRootto prevent potential NPEs. ReplacedServiceManagerwith the modernproject.getServicefor retrievingSettingsinstances. Additionally, updated workflows to run tests via a script and introduced new test fixtures for UI testing.