#38565 Avoid crash of min-height converter when a mobile value is defined but key does not exist #896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… not undefined to avoid split to crash if the key does not exist.
|
@magento run all tests |
|
@magento run all tests |
|
Hello @bhennesAdv, It seems you are still working on it, hence moving this PR Thanks |
engcom-Hotel
moved this from Changes Requested
to On Hold
in Pull Request Progress - PageBuilder
ct-prd-projects-boards-automation
bot
moved this from On Hold
to Ready for Review
in Pull Request Progress - PageBuilder
|
Hello @engcom-Hotel I would say that everything is finished as static tests are now OK (It was the only issue when I looked at it). I'll let you know if all tests passed or I'll check it if there is some issues. |
engcom-Hotel
moved this from Ready for Review
to On Hold
in Pull Request Progress - PageBuilder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@see magento/magento2#38565 for issue description
I'm not doing typescript at all, so I just ported the same correction as it would probably not crash.
Maybe the template function get() automatically casts the returned value to string to it might be overkill.
I let typescript experts judge on this.