-
Notifications
You must be signed in to change notification settings - Fork 165
Simplify installation instructions #436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @fredden Thanks for your update.
Please review my comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Looks good for me
|
@magento import PR to magento-commerce/magento-coding-standard repository |
|
@sinhaparul the Pull Request is successfully imported. |
6d8a941 to
afe826d
Compare
afe826d to
2d3d36e
Compare
2d3d36e to
e43bd79
Compare
556edd4 to
7143ee5
Compare
bb1bc39 to
faca601
Compare
c11b4c6 to
76037c6
Compare
The installation instructions for this coding standard are unnecessarily complex. Composer plugins are capable of performing the necessary registration automatically, without requiring the user to manually set up (or alter) any
scriptssections incomposer.json. The main Magento repository usesdealerdirect/phpcodesniffer-composer-installerto register the coding standard; let's use the same here.See https://github.com/magento/magento2/blob/11846a1a10539470f2fe1522030ff42d62daa562/composer.json#L110 / magento/magento2#36791
Fixes #390