Fix phpcs issues

Magento2/Tests/Eslint/AbstractEslintTestCase.php

@@ -17,18 +17,21 @@
 abstract class AbstractEslintTestCase extends TestCase
 {
     /**
+     * Assert that file contains a specific error.
+     *
      * @param string $testFile
      * @param array $expectedMessages
      */
     protected function assertFileContainsError(string $testFile, array $expectedMessages): void
     {
+        // phpcs:disable
         exec(
             'npm run eslint -- Magento2/Tests/Eslint/' . $testFile,
             $output
         );
 
         foreach ($expectedMessages as $message) {
-            $this->assertStringContainsString($message, implode(' ',$output));
+            $this->assertStringContainsString($message, implode(' ', $output));
         }
     }
 }

Magento2/Tests/Eslint/ClickEventShorthandTest.php

@@ -21,4 +21,4 @@ public function testExecute(): void
             ['Instead of .blur(fn) use .on("blur", fn). Instead of .blur() use .trigger("blur")']
         );
     }
-}
+}

Magento2/Tests/Eslint/DelegateUndelegateTest.php

@@ -21,4 +21,4 @@ public function testExecute(): void
             ['jQuery $.delegate and $.undelegate are deprecated, use $.on and $.off instead']
         );
     }
-}
+}

Magento2/Tests/Eslint/EventShorthandTest.php

@@ -21,4 +21,4 @@ public function testExecute(): void
             ['jQuery.load() was removed, use .on("load", fn) instead']
         );
     }
-}
+}

Magento2/Tests/Eslint/SizeTest.php

@@ -21,4 +21,4 @@ public function testExecute(): void
             ['jQuery.size() removed, use jQuery.length']
         );
     }
-}
+}

Magento2/Tests/Eslint/TrimTest.php

@@ -21,4 +21,4 @@ public function testExecute(): void
             ['jQuery.trim is deprecated; use String.prototype.trim']
         );
     }
-}
+}

Magento2/Tests/Legacy/InstallUpgradeUnitTest.php

@@ -12,6 +12,9 @@
 
 class InstallUpgradeUnitTest extends AbstractSniffUnitTest
 {
+    /**
+     * @var string[]
+     */
     private $wrongFileNames = [
         'data-install-.inc',
         'data-upgrade-.inc',

Magento2/Tests/Legacy/PhtmlTemplateUnitTest.php

@@ -67,8 +67,7 @@ public function getWarningList($testFile = '')
                 39 => 1
             ];
         }
-        if ($testFile === 'PhtmlTemplateUnitTest.3.phtml')
-        {
+        if ($testFile === 'PhtmlTemplateUnitTest.3.phtml') {
             return [
                 9 => 1,
                 20 => 1,

Magento2/Tests/Legacy/_files/RestrictedCodeUnitTest/Magento/Framework/Model/ResourceModel/Iterator.php

@@ -1,11 +1,11 @@
 <?php
-
-use PHP_CodeSniffer\Tests\Standards\AbstractSniffUnitTest;
-
 /**
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+namespace Magento2\Tests\Legacy\_files\RestrictedCodeUnitTest\Magento\Framework\Model\ResourceModel;
+
+use PHP_CodeSniffer\Tests\Standards\AbstractSniffUnitTest;
 
 /**
  * This is NOT actually a test, but a file that must be ignored by RestrictedCodeSniff
@@ -15,20 +15,23 @@
  */
 class IteratorDummyFile extends AbstractSniffUnitTest
 {
-    protected function shouldSkipTest()
+    protected function shouldSkipTest(): bool
     {
         return true;
     }
 
-    protected function getErrorList() {
+    protected function getErrorList(): array
+    {
         return [];
     }
 
-    protected function getWarningList() {
+    protected function getWarningList(): array
+    {
         return [];
     }
 
-    private function withProtectedClass() {
+    private function withProtectedClass(): Zend_Db_Expr
+    {
         return new \Zend_Db_Expr();
     }
 }

Magento2/Tests/PHPCompatibility/AbstractPrivateMethodsUnitTest.php

@@ -56,7 +56,6 @@ public function dataForbiddenAbstractPrivateMethods()
         ];
     }
 
-
     /**
      * Verify that the sniff throws an error for abstract private methods in traits for PHP 7.4
      * and doesn't for PHP 8.0.
@@ -91,7 +90,6 @@ public function dataNewTraitAbstractPrivateMethods()
         ];
     }
 
-
     /**
      * Verify the sniff does not throw false positives for valid code.
      *
@@ -128,7 +126,6 @@ public function dataNoFalsePositives()
         return $cases;
     }
 
-
     /**
      * Verify no notices are thrown at all.
      *

Magento2/Tests/PHPCompatibility/BaseSniffTest.php

@@ -39,7 +39,7 @@ class BaseSniffTest extends TestCase
      *
      * @var string
      */
-    const STANDARD_NAME = 'Magento2';
+    private const STANDARD_NAME = 'Magento2';
 
     /**
      * The PHP_CodeSniffer object used for testing.

Magento2/Tests/PHPCompatibility/ChangedIntToBoolParamTypeUnitTest.php

@@ -63,7 +63,6 @@ public function dataChangedIntToBoolParamType()
         ];
     }
 
-
     /**
      * Verify no false positives are thrown for valid code.
      *
@@ -98,7 +97,6 @@ public function dataNoFalsePositives()
         return $data;
     }
 
-
     /**
      * Verify no notices are thrown at all.
      *

Magento2/Tests/PHPCompatibility/ForbiddenFinalPrivateMethodsUnitTest.php

@@ -57,7 +57,6 @@ public function dataForbiddenFinalPrivateMethods()
         ];
     }
 
-
     /**
      * Verify the sniff does not throw false positives for valid code.
      *
@@ -91,7 +90,6 @@ public function dataNoFalsePositives()
         return $cases;
     }
 
-
     /**
      * Verify no notices are thrown at all.
      *

Magento2/Tests/PHPCompatibility/NewAttributesUnitTest.php

@@ -107,7 +107,6 @@ public function dataNewAttributes()
         return $data;
     }
 
-
     /**
      * Verify the sniff does not throw false positives for valid code.
      *
@@ -142,7 +141,6 @@ public function dataNoFalsePositives()
         return $data;
     }
 
-
     /**
      * Verify no notices are thrown at all.
      *

Magento2/Tests/PHPCompatibility/NewInterpolatedStringDereferencingUnitTest.php

@@ -10,7 +10,6 @@
 
 namespace Magento2\Tests\PHPCompatibility;
 
-
 /**
  * Test the NewInterpolatedStringDereferencing sniff.
  *

Magento2/Tests/PHPCompatibility/NewMagicClassConstantUnitTest.php

@@ -10,7 +10,6 @@
 
 namespace Magento2\Tests\PHPCompatibility;
 
-
 /**
  * Test the NewMagicClassConstant sniff.
  *
@@ -63,7 +62,6 @@ public function dataNewMagicClassConstant()
         ];
     }
 
-
     /**
      * Verify that no false positives are thrown for valid code.
      *
@@ -96,7 +94,6 @@ public function dataNoFalsePositives()
         ];
     }
 
-
     /**
      * Test correctly identifying the magic class constant when used on instantiated objects.
      *
@@ -136,7 +133,6 @@ public function dataNewMagicClassConstantOnObject()
         ];
     }
 
-
     /**
      * Verify no notices are thrown at all.
      *

Magento2/Tests/PHPCompatibility/NewMagicConstantDereferencingUnitTest.php

@@ -10,7 +10,6 @@
 
 namespace Magento2\Tests\PHPCompatibility;
 
-
 /**
  * Test the NewMagicConstantDereferencing sniff.
  *
@@ -60,7 +59,6 @@ public function dataNewMagicConstantDereferencing()
         ];
     }
 
-
     /**
      * Verify the sniff does not throw false positives for valid code, nor for code which is still invalid.
      *
@@ -99,7 +97,6 @@ public function dataNoFalsePositives()
         ];
     }
 
-
     /**
      * Verify no notices are thrown at all.
      *

Magento2/Tests/PHPCompatibility/NewNestedStaticAccessUnitTest.php

@@ -69,7 +69,6 @@ public function dataNestedStaticAccess()
         ];
     }
 
-
     /**
      * Verify that class constant dereferencing emits an error in PHP 7.4.
      *
@@ -100,7 +99,6 @@ public function dataClassConstantDereferencing()
         ];
     }
 
-
     /**
      * Verify the sniff doesn't throw false positives.
      *
@@ -133,7 +131,6 @@ public function dataNoFalsePositives()
         ];
     }
 
-
     /**
      * Verify no notices are thrown at all.
      *

Magento2/Tests/PHPCompatibility/NewNonCapturingCatchUnitTest.php

@@ -56,7 +56,6 @@ public function dataNewNonCapturingCatch()
         ];
     }
 
-
     /**
      * Verify no false positives are thrown for valid code.
      *
@@ -89,7 +88,6 @@ public function dataNoFalsePositives()
         ];
     }
 
-
     /**
      * Verify no notices are thrown at all.
      *

Magento2/Tests/PHPCompatibility/NewTrailingCommaUnitTest.php

@@ -58,7 +58,6 @@ public function dataTrailingComma()
         ];
     }
 
-
     /**
      * Test correctly identifying trailing comma's in closure use lists.
      *
@@ -90,7 +89,6 @@ public function dataTrailingCommaClosureUse()
         ];
     }
 
-
     /**
      * Verify the sniff does not throw false positives for valid code.
      *
@@ -127,7 +125,6 @@ public function dataNoFalsePositives()
         return $data;
     }
 
-
     /**
      * Verify no notices are thrown at all.
      *

Magento2/Tests/PHPCompatibility/RemovedAssertStringAssertionUnitTest.php

@@ -60,7 +60,6 @@ public function dataRemovedAssertStringAssertion()
         ];
     }
 
-
     /**
      * Verify there are no false positives on code this sniff should ignore.
      *

Magento2/Tests/PHPCompatibility/RemovedCallingDestructAfterConstructorExitUnitTest.php

@@ -10,7 +10,6 @@
 
 namespace Magento2\Tests\PHPCompatibility;
 
-
 /**
  * Test the RemovedCallingDestructAfterConstructorExit sniff.
  *
@@ -66,7 +65,6 @@ public function dataRemovedCallingDestructAfterConstructorExit()
         ];
     }
 
-
     /**
      * Verify the sniff does not throw false positives for valid code.
      *
@@ -107,7 +105,6 @@ public function dataNoFalsePositives()
         return $cases;
     }
 
-
     /**
      * Verify no notices are thrown at all.
      *

Magento2/Tests/PHPCompatibility/RemovedGetDefinedFunctionsExcludeDisabledFalseUnitTest.php

@@ -52,7 +52,6 @@ public function dataRemovedGetDefinedFunctionsExcludeDisabledFalse()
         ];
     }
 
-
     /**
      * Verify the sniff does not throw false positives for valid code.
      *
@@ -68,7 +67,6 @@ public function testNoFalsePositives()
         }
     }
 
-
     /**
      * Verify no notices are thrown at all.
      *

Magento2/Tests/PHPCompatibility/RemovedOptionalBeforeRequiredParamUnitTest.php

@@ -58,7 +58,6 @@ public function dataRemovedOptionalBeforeRequiredParam()
         ];
     }
 
-
     /**
      * Verify the sniff does not throw false positives for valid code.
      *
@@ -103,7 +102,6 @@ public function dataNoFalsePositives()
         return $cases;
     }
 
-
     /**
      * Verify no notices are thrown at all.
      *