Fix phpcs issues

.github/workflows/php.yml

@@ -54,10 +54,10 @@ jobs:
       run: vendor/bin/phpunit
 
     - name: Run code style suite
-      run: vendor/bin/phpcs --standard=Magento2 Magento2/Helpers Magento2/Sniffs Magento2Framework/Sniffs
+      run: vendor/bin/phpcs --standard=Magento2 Magento2/Helpers Magento2/Sniffs Magento2/Rector Magento2Framework/Sniffs
 
     - name: Run framework suite
-      run: vendor/bin/phpcs --standard=Magento2Framework Magento2/Helpers Magento2/Sniffs Magento2Framework/Sniffs
+      run: vendor/bin/phpcs --standard=Magento2Framework Magento2/Helpers Magento2/Sniffs Magento2/Rector Magento2Framework/Sniffs
   js:
     runs-on: ubuntu-latest
     name: Javascript tests

Magento2/Rector/Src/AddArrayAccessInterfaceReturnTypes.php

@@ -10,22 +10,21 @@
 use PhpParser\Node;
 use PhpParser\Node\Stmt\Class_;
 use Rector\Core\Rector\AbstractRector;
-use Symplify\RuleDocGenerator\Exception\PoorDocumentationException;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
 
-final class AddArrayAccessInterfaceReturnTypes extends AbstractRector
+class AddArrayAccessInterfaceReturnTypes extends AbstractRector
 {
     /**
-     * @return array<class-string<Node>>
+     * @inheritDoc
      */
     public function getNodeTypes(): array
     {
         return [Class_::class];
     }
 
     /**
-     * @param Class_ $node
+     * @inheritDoc
      */
     public function refactor(Node $node): ?Node
     {
@@ -52,13 +51,13 @@ public function refactor(Node $node): ?Node
     }
 
     /**
-     * @return RuleDefinition
-     * @throws PoorDocumentationException
+     * @inheritDoc
      */
     public function getRuleDefinition(): RuleDefinition
     {
         return new RuleDefinition(
-            'Add return types specified by ArrayAccess interface', [
+            'Add return types specified by ArrayAccess interface',
+            [
                 new CodeSample(
                     'public function offsetSet($offset, $value)',
                     'public function offsetSet($offset, $value): void'

Magento2/Rector/Src/ReplaceMbStrposNullLimit.php

@@ -11,22 +11,21 @@
 use PhpParser\Node\Expr\FuncCall;
 use PhpParser\Node\Scalar\LNumber;
 use Rector\Core\Rector\AbstractRector;
-use Symplify\RuleDocGenerator\Exception\PoorDocumentationException;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
 
-final class ReplaceMbStrposNullLimit extends AbstractRector
+class ReplaceMbStrposNullLimit extends AbstractRector
 {
     /**
-     * @return array<class-string<Node>>
+     * @inheritDoc
      */
     public function getNodeTypes(): array
     {
         return [FuncCall::class];
     }
 
     /**
-     * @param FuncCall $node
+     * @inheritDoc
      */
     public function refactor(Node $node): ?Node
     {
@@ -43,13 +42,13 @@ public function refactor(Node $node): ?Node
     }
 
     /**
-     * @return RuleDefinition
-     * @throws PoorDocumentationException
+     * @inheritDoc
      */
     public function getRuleDefinition(): RuleDefinition
     {
         return new RuleDefinition(
-            'Change mb_strpos offset from null to 0', [
+            'Change mb_strpos offset from null to 0',
+            [
                 new CodeSample(
                     'mb_strpos("pattern", "subject", null, "encoding");',
                     'mb_strpos("pattern", "subject", 0, "encoding");'

Magento2/Rector/Src/ReplaceNewDateTimeNull.php

@@ -11,22 +11,21 @@
 use PhpParser\Node\Expr\New_;
 use PhpParser\Node\Scalar\String_;
 use Rector\Core\Rector\AbstractRector;
-use Symplify\RuleDocGenerator\Exception\PoorDocumentationException;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
 
-final class ReplaceNewDateTimeNull extends AbstractRector
+class ReplaceNewDateTimeNull extends AbstractRector
 {
     /**
-     * @return array<class-string<Node>>
+     * @inheritDoc
      */
     public function getNodeTypes(): array
     {
         return [New_::class];
     }
 
     /**
-     * @param New_ $node
+     * @inheritDoc
      */
     public function refactor(Node $node): ?Node
     {
@@ -43,13 +42,13 @@ public function refactor(Node $node): ?Node
     }
 
     /**
-     * @return RuleDefinition
-     * @throws PoorDocumentationException
+     * @inheritDoc
      */
     public function getRuleDefinition(): RuleDefinition
     {
         return new RuleDefinition(
-            'Change DateTime datetime input from null to "now"', [
+            'Change DateTime datetime input from null to "now"',
+            [
                 new CodeSample(
                     'new DateTime(null, new DateTimeZone("GMT"));',
                     'new DateTime("now", new DateTimeZone("GMT"));'

Magento2/Rector/Src/ReplacePregSplitNullLimit.php

@@ -11,22 +11,21 @@
 use PhpParser\Node\Expr\FuncCall;
 use PhpParser\Node\Scalar\LNumber;
 use Rector\Core\Rector\AbstractRector;
-use Symplify\RuleDocGenerator\Exception\PoorDocumentationException;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
 
-final class ReplacePregSplitNullLimit extends AbstractRector
+class ReplacePregSplitNullLimit extends AbstractRector
 {
     /**
-     * @return array<class-string<Node>>
+     * @inheritDoc
      */
     public function getNodeTypes(): array
     {
         return [FuncCall::class];
     }
 
     /**
-     * @param FuncCall $node
+     * @inheritDoc
      */
     public function refactor(Node $node): ?Node
     {
@@ -43,13 +42,13 @@ public function refactor(Node $node): ?Node
     }
 
     /**
-     * @return RuleDefinition
-     * @throws PoorDocumentationException
+     * @inheritDoc
      */
     public function getRuleDefinition(): RuleDefinition
     {
         return new RuleDefinition(
-            'Change preg_split limit from null to -1', [
+            'Change preg_split limit from null to -1',
+            [
                 new CodeSample(
                     'preg_split("pattern", "subject", null, 0);',
                     'preg_split("pattern", "subject", -1, 0);'

Magento2/Rector/Tests/AddArrayAccessInterfaceReturnTypes/AddArrayAccessInterfaceReturnTypesTest.php

@@ -11,7 +11,7 @@
 use Rector\Testing\PHPUnit\AbstractRectorTestCase;
 use Symplify\SmartFileSystem\SmartFileInfo;
 
-final class AddArrayAccessInterfaceReturnTypesTest extends AbstractRectorTestCase
+class AddArrayAccessInterfaceReturnTypesTest extends AbstractRectorTestCase
 {
     /**
      * @dataProvider provideData()

Magento2/Rector/Tests/ReplaceMbStrposNullLimit/ReplaceMbStrposNullLimitTest.php

@@ -11,7 +11,7 @@
 use Rector\Testing\PHPUnit\AbstractRectorTestCase;
 use Symplify\SmartFileSystem\SmartFileInfo;
 
-final class ReplaceMbStrposNullLimitTest extends AbstractRectorTestCase
+class ReplaceMbStrposNullLimitTest extends AbstractRectorTestCase
 {
     /**
      * @dataProvider provideData()
@@ -29,6 +29,9 @@ public function provideData(): Iterator
         return $this->yieldFilesFromDirectory(__DIR__ . '/Fixture');
     }
 
+    /**
+     * @return string
+     */
     public function provideConfigFilePath(): string
     {
         return __DIR__ . '/config/configured_rule.php';

Magento2/Rector/Tests/ReplaceNewDateTimeNull/ReplaceNewDateTimeNullTest.php

@@ -11,7 +11,7 @@
 use Rector\Testing\PHPUnit\AbstractRectorTestCase;
 use Symplify\SmartFileSystem\SmartFileInfo;
 
-final class ReplaceNewDateTimeNullTest extends AbstractRectorTestCase
+class ReplaceNewDateTimeNullTest extends AbstractRectorTestCase
 {
     /**
      * @dataProvider provideData()

Magento2/Rector/Tests/ReplacePregSplitNullLimit/ReplacePregSplitNullLimitTest.php

@@ -11,7 +11,7 @@
 use Rector\Testing\PHPUnit\AbstractRectorTestCase;
 use Symplify\SmartFileSystem\SmartFileInfo;
 
-final class ReplacePregSplitNullLimitTest extends AbstractRectorTestCase
+class ReplacePregSplitNullLimitTest extends AbstractRectorTestCase
 {
     /**
      * @dataProvider provideData()

Magento2/Tests/Eslint/AbstractEslintTestCase.php

@@ -17,18 +17,21 @@
 abstract class AbstractEslintTestCase extends TestCase
 {
     /**
+     * Assert that file contains a specific error.
+     *
      * @param string $testFile
      * @param array $expectedMessages
      */
     protected function assertFileContainsError(string $testFile, array $expectedMessages): void
     {
+        // phpcs:disable
         exec(
             'npm run eslint -- Magento2/Tests/Eslint/' . $testFile,
             $output
         );
 
         foreach ($expectedMessages as $message) {
-            $this->assertStringContainsString($message, implode(' ',$output));
+            $this->assertStringContainsString($message, implode(' ', $output));
         }
     }
 }

Magento2/Tests/Eslint/ClickEventShorthandTest.php

@@ -21,4 +21,4 @@ public function testExecute(): void
             ['Instead of .blur(fn) use .on("blur", fn). Instead of .blur() use .trigger("blur")']
         );
     }
-}
+}

Magento2/Tests/Eslint/DelegateUndelegateTest.php

@@ -21,4 +21,4 @@ public function testExecute(): void
             ['jQuery $.delegate and $.undelegate are deprecated, use $.on and $.off instead']
         );
     }
-}
+}

Magento2/Tests/Eslint/EventShorthandTest.php

@@ -21,4 +21,4 @@ public function testExecute(): void
             ['jQuery.load() was removed, use .on("load", fn) instead']
         );
     }
-}
+}

Magento2/Tests/Eslint/SizeTest.php

@@ -21,4 +21,4 @@ public function testExecute(): void
             ['jQuery.size() removed, use jQuery.length']
         );
     }
-}
+}

Magento2/Tests/Eslint/TrimTest.php

@@ -21,4 +21,4 @@ public function testExecute(): void
             ['jQuery.trim is deprecated; use String.prototype.trim']
         );
     }
-}
+}

Magento2/Tests/Legacy/InstallUpgradeUnitTest.php

@@ -12,6 +12,9 @@
 
 class InstallUpgradeUnitTest extends AbstractSniffUnitTest
 {
+    /**
+     * @var string[]
+     */
     private $wrongFileNames = [
         'data-install-.inc',
         'data-upgrade-.inc',

Magento2/Tests/Legacy/PhtmlTemplateUnitTest.php

@@ -67,8 +67,7 @@ public function getWarningList($testFile = '')
                 39 => 1
             ];
         }
-        if ($testFile === 'PhtmlTemplateUnitTest.3.phtml')
-        {
+        if ($testFile === 'PhtmlTemplateUnitTest.3.phtml') {
             return [
                 9 => 1,
                 20 => 1,

Magento2/Tests/Legacy/_files/RestrictedCodeUnitTest/Magento/Framework/Model/ResourceModel/Iterator.php

@@ -1,11 +1,11 @@
 <?php
-
-use PHP_CodeSniffer\Tests\Standards\AbstractSniffUnitTest;
-
 /**
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+namespace Magento2\Tests\Legacy\_files\RestrictedCodeUnitTest\Magento\Framework\Model\ResourceModel;
+
+use PHP_CodeSniffer\Tests\Standards\AbstractSniffUnitTest;
 
 /**
  * This is NOT actually a test, but a file that must be ignored by RestrictedCodeSniff
@@ -15,20 +15,23 @@
  */
 class IteratorDummyFile extends AbstractSniffUnitTest
 {
-    protected function shouldSkipTest()
+    protected function shouldSkipTest(): bool
     {
         return true;
     }
 
-    protected function getErrorList() {
+    protected function getErrorList(): array
+    {
         return [];
     }
 
-    protected function getWarningList() {
+    protected function getWarningList(): array
+    {
         return [];
     }
 
-    private function withProtectedClass() {
+    private function withProtectedClass(): Zend_Db_Expr
+    {
         return new \Zend_Db_Expr();
     }
 }

Magento2/Tests/PHPCompatibility/AbstractPrivateMethodsUnitTest.php

@@ -56,7 +56,6 @@ public function dataForbiddenAbstractPrivateMethods()
         ];
     }
 
-
     /**
      * Verify that the sniff throws an error for abstract private methods in traits for PHP 7.4
      * and doesn't for PHP 8.0.
@@ -91,7 +90,6 @@ public function dataNewTraitAbstractPrivateMethods()
         ];
     }
 
-
     /**
      * Verify the sniff does not throw false positives for valid code.
      *
@@ -128,7 +126,6 @@ public function dataNoFalsePositives()
         return $cases;
     }
 
-
     /**
      * Verify no notices are thrown at all.
      *

Magento2/Tests/PHPCompatibility/BaseSniffTest.php

@@ -39,7 +39,7 @@ class BaseSniffTest extends TestCase
      *
      * @var string
      */
-    const STANDARD_NAME = 'Magento2';
+    private const STANDARD_NAME = 'Magento2';
 
     /**
      * The PHP_CodeSniffer object used for testing.