-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Update documentation to match new feature - localised error pages #9363
Update documentation to match new feature - localised error pages #9363
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice update - one tiny change - we don't use contractions in DEVDOCS as some people don't have English as a first language.
src/guides/v2.3/install-gde/install/cli/install-cli-subcommands-maint.md
Outdated
Show resolved
Hide resolved
…s-maint.md Co-authored-by: Barny Shergold <[email protected]>
@magento import pr to magento-devdocs/devdocs |
@dobooth the Pull Request is successfully imported. |
It's weird that this PR got merged months ago, even though the PR that tries to introduce this feature is not merged yet in the M2 codebase. This gives false information on the devdocs site at the moment, no? |
Good catch @hostep. Thanks for bringing it to our attention. @dobooth, will you please revert these changes both in this repo and the new location in the commerce-operations.en repo? It's unclear to me when the code PR is going to be merged, but we need to find out so we can prep the necessary change for the necessary release integration branch for docs. |
Reverted. Will keep an eye on the codebase PR. |
Purpose of this pull request
This pull request updates the documentation regarding localised error pages. This is a companion to magento/magento2#35095 where the referenced feature is being introduced.
Affected DevDocs pages
Links to Magento source code