Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Update documentation to match new feature - localised error pages #9363

Merged

Conversation

fredden
Copy link
Member

@fredden fredden commented Feb 13, 2022

Purpose of this pull request

This pull request updates the documentation regarding localised error pages. This is a companion to magento/magento2#35095 where the referenced feature is being introduced.

Affected DevDocs pages

Links to Magento source code

Copy link
Contributor

@BarnyShergold BarnyShergold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice update - one tiny change - we don't use contractions in DEVDOCS as some people don't have English as a first language.

@dobooth dobooth added Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies 2.3.x Magento 2.3 related changes 2.4.x Magento 2.4.x related changes labels Feb 16, 2022
@dobooth
Copy link
Contributor

dobooth commented Feb 16, 2022

@magento import pr to magento-devdocs/devdocs

@m2-github-services
Copy link

@dobooth the Pull Request is successfully imported.

@hostep
Copy link
Contributor

hostep commented Nov 15, 2022

It's weird that this PR got merged months ago, even though the PR that tries to introduce this feature is not merged yet in the M2 codebase. This gives false information on the devdocs site at the moment, no?

@jeff-matthews
Copy link
Contributor

jeff-matthews commented Nov 15, 2022

Good catch @hostep. Thanks for bringing it to our attention.

@dobooth, will you please revert these changes both in this repo and the new location in the commerce-operations.en repo?

It's unclear to me when the code PR is going to be merged, but we need to find out so we can prep the necessary change for the necessary release integration branch for docs.

@dobooth
Copy link
Contributor

dobooth commented Nov 16, 2022

Reverted. Will keep an eye on the codebase PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.3.x Magento 2.3 related changes 2.4.x Magento 2.4.x related changes Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies Partner: Fisheye partners-contribution PR created by Magento partner Progress: done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants