Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix delete button logic #1100

Merged
merged 3 commits into from
Jan 4, 2025

Conversation

CarlosABVA
Copy link
Contributor

@CarlosABVA CarlosABVA commented Dec 23, 2024

Fixes #958.

About the edit note on the issue, I haven´t been able to replicate an account with splits that could be deleted

@argaen
Copy link
Contributor

argaen commented Dec 23, 2024

I haven´t been able to replicate an account with splits that could be deleted

Actually.... I just discovered why you can't reproduce. So the problem here is the partial data loaded during the period. As in, if you select a period of three months, we only load the splits for those three months for that account so the condition of splits.length === 0 will be true. You can try it, I was able to reproduce it.

However, your code already improves current behavior so I'm happy to merge as long as we add a test and fix the pipeline! If you need a hand, happy to help.

@CarlosABVA CarlosABVA marked this pull request as ready for review December 25, 2024 17:45
@CarlosABVA
Copy link
Contributor Author

CarlosABVA commented Dec 25, 2024

However, your code already improves current behavior so I'm happy to merge as long as we add a test and fix the pipeline! If you need a hand, happy to help.

Alrite I added a couple tests to cover the updated logic. About the failing pipeline, SonarCloud is complaining about a missing token, not sure where this comes from

@argaen
Copy link
Contributor

argaen commented Jan 4, 2025

looks good, merging!

ignoring the scanner error since tests + lint passed

@argaen argaen merged commit 7659576 into maffin-io:master Jan 4, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't let parent accounts with children to be deleted
2 participants