Experiment with parse toml #6
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Declarative custom data (https://shopify.dev/beta/next-gen-dev-platform/declarative-custom-data-definitions) will allow to create metafield and metaobject definitions directly in a schema. This is, more or less, what this library was doing for the createFromSchema.
However, declarative custom data offers a lot of advantages:
While the feature is not yet available, I think it will be better to wait for a stable release and integrate with this instead. However, because the schema is no longer available as a const, all the TypeScript magic and schema knowledge can't be done anymore.
One approach I'm considering is bundling a CLI tool to generate various things based on the schema found in the TOML file.
Generating types
Considering a schema, this would generate types for the models. For instance considering this:
This would generate this:
Emitting metadata
The library itself needs to know a few things about the schema. This helps knowing how to optimize queries (for instance, knowing if we must fetch references, what are their type... and so on).
To do that, I think the library should also, from this schema, create a global metadata, that could be re-used by the library:
When we populate a reference, we would therefore now know the type.