-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix(Security): Re-define AuthorizationExecuteWithPrivileges #712
Conversation
61cfab8
to
0864d68
Compare
Fixes #711. Signed-off-by: Paul Mabileau <[email protected]>
0864d68
to
8450ae2
Compare
@madsmtm would it be possible to review this, please? Doing so somewhat soon would help avoid having to rebase this regularly to fix conflicts since it touches the generated modules. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, that was fast 😄
That's alright 👌 |
I typed that before you wrote your comment, got a notification ping because you rebased ;) |
Thanks! Do you know if it would be possible to publish a 0.3.1 patch release for |
I'm still unsure, but I think I'd prefer to have framework crates synchronized, yeah. |
Have created a milestone with a reasonable deadline (which, as you know, I'm terrible at, but hopefully this one won't be as stressful). |
Given the quantity, that's definitely understandable 👌
Seems fair, thanks!
😅 |
Fixes #711 by manually re-defining the problematic function. Another possibility could have been to add a patch system that runs on the SDK before generating the modules since the bug comes from there, but I don't think it exists yet and one could consider it overkill for this small need. In the meantime, this works.