Add more ServiceManagement functions #698
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
added
enhancement
madsmtm
pushed a commit
that referenced
this pull request
Jan 20, 2025
madsmtm
approved these changes
Jan 20, 2025
There was a problem hiding this comment.
Thanks! This indeed makes sense to have, as SMAppService is only available in newer macOS versions, it was just an oversight when I added CoreFoundation support to not add this too.
I've merged this in 6b8a6d1, I decided to make objc2-core-foundation optional as well, and to not include the changelog entry, since objc2-core-foundation was added in this (yet to be released) version, and there's a lot of similar additions that also aren't noted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have allowed the
ServiceManagementframework crate to have more functions, in particular I was missingSMJobBless. I see that previously functions referring to CoreFoundation were not generated. I might not have all the context on why that was, so please tell me if I did something incorrectly.