Fix S3 pagination bug in ValidatorS3Access #690
Merged
+116
−83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously _get_all_s3_data() called _request_presigned_list_url(continuation_token), so the continuation token was incorrectly passed as the miner_hotkey argument and the real continuation_token was never sent, breaking pagination and often returning no data from /get-miner-list. The fix makes _get_all_s3_data accept a miner_hotkey parameter and pass both miner_hotkey and continuation_token explicitly into _request_presigned_list_url. Call sites were updated so _list_jobs_cached and list_files now call _get_all_s3_data(miner_hotkey), ensuring per-miner listing works correctly and S3 pagination behaves as intended. Signed-off-by: Real Noob <[email protected]>
Collaborator
|
tested working great! |
Arrmlet
approved these changes
Nov 25, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously _get_all_s3_data() called _request_presigned_list_url(continuation_token), so the continuation token was incorrectly passed as the miner_hotkey argument and the real continuation_token was never sent, breaking pagination and often returning no data from /get-miner-list. The fix makes _get_all_s3_data accept a miner_hotkey parameter and pass both miner_hotkey and continuation_token explicitly into _request_presigned_list_url. Call sites were updated so _list_jobs_cached and list_files now call _get_all_s3_data(miner_hotkey), ensuring per-miner listing works correctly and S3 pagination behaves as intended.