Fixed user_display_name/S3 job content matching crash by removing pd.… #686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…notna() Fixed user_display_name so it’s treated as an optional field (None when missing/NaN) instead of silently falling back to username. Fixed S3 job content matching crash by removing pd.notna() checks on array-like tweet_hashtags and safely normalizing them to a list. Job label/keyword matching now works reliably for X/Twitter without ambiguous truth value errors. PLease enforce the job time window using post_start_datetime and post_end_datetime when validating S3 content. Signed-off-by: Real Noob <[email protected]>
Arrmlet
approved these changes
Nov 25, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…notna()
Fixed user_display_name so it’s treated as an optional field (None when missing/NaN) instead of silently falling back to username. Fixed S3 job content matching crash by removing pd.notna() checks on array-like tweet_hashtags and safely normalizing them to a list. Job label/keyword matching now works reliably for X/Twitter without ambiguous truth value errors.
PLease enforce the job time window using post_start_datetime and post_end_datetime when validating S3 content.