Added Word Wrap as a global setting and some formatting to the Settings page #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated with wrap tests at bottom
added word wrap global setting and formatting
Added word wrap global setting
Added word-wrap from global settings value.
mProjectsCode
requested changes
Apr 23, 2024
| @@ -138,6 +138,7 @@ export default class ShikiPlugin extends Plugin { | |||
| themeCssRoot: 'div.expressive-code', | |||
| defaultProps: { | |||
| showLineNumbers: false, | |||
| wrap: this.settings.wrapGlobal, | |||
There was a problem hiding this comment.
For consistency, you should probably access this.loadedSettings instead.
| // Theme | ||
| const ThemeDesc = new DocumentFragment() | ||
| ThemeDesc.createSpan({}, span => { | ||
| span.innerHTML = `Select the theme for the code blocks.<br/> |
There was a problem hiding this comment.
Don't use innerHTML, even if it is a "secure" string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for the plugin!
I added a little bit of formatting to the settings page so that it's easy to keep consistent if you ever want to expand the values quickly.
I added a global word wrap variable to toggle on/off in settings and apply as appropriate. I tested that the in-line settings will override as well.
The default is word-wrap on, but you may wish to make that false by default. :)
Cheers!