test: updated setup for identity tests #1105

jaissica12 · 2025-10-20T14:51:55Z

Background

Evaluating Setup and Teardowns for each test file

What Has Changed

Updated test files:
- test/src/tests-identities-attributes.ts
- test/src/tests-identity.ts
- test/src/tests-identityApiClient.ts

Screenshots/Video

{Include any screenshots or video demonstrating the new feature or fix, if applicable}

Checklist

I have performed a self-review of my own code.
I have made corresponding changes to the documentation.
I have added tests that prove my fix is effective or that my feature works.
I have tested this locally.

Additional Notes

{Any additional information or context relevant to this PR}

Reference Issue (For employees only. Ignore if you are an outside contributor)

Closes https://rokt.atlassian.net/browse/SDKE-399

rmi22186 · 2025-10-25T02:50:15Z

test/karma.config.js

            captureConsole,
            mocha: {
-                timeout: 5000 // 5 seconds.  Increase from default 2 seconds.
+                timeout: 10000 // 10 seconds.  Increase from default 2 seconds.


Strange, still seeing a 2000 ms issue here for firefox

nevermind, may be the comment i left above actually in the utils.js file for waitForCondition instead

rmi22186 · 2025-10-25T02:51:03Z

test/src/config/utils.js

    waitForCondition = function async(
        conditionFn,
-        timeout = 200,
+        timeout = 2000,


i realize i commented below seeing that there was still a 2000ms timeout for firefox, but i realize maybe that's here instead

rmi22186 · 2025-10-25T02:56:56Z

test/src/tests-identities-attributes.ts

+        await waitForCondition(hasIdentityCallInflightReturned);
        await waitForCondition(() => {


this should be either the await you added OR the await that's already here. there isn't really a reason to have both. I'd test again using just the bottom one, because the fetchMock on line 1051 i the reason the current waitForConfition should be working. if the one you added is more reliable though, that's fine

rmi22186 · 2025-10-25T03:03:46Z

test/src/tests-identities-attributes.ts

+        await waitForCondition(() => {
+            const currentUser = mParticle.Identity.getCurrentUser();
+            const userIdentities = currentUser?.getUserIdentities()?.userIdentities;
+            return userIdentities && 
+                   userIdentities.customerid === 'customerid1' &&
+                   userIdentities.email === '[email protected]';
+        });


I think I see why the waitForCondition for identityCallInFlight === false may not be reliable. because it is set to false BEFORE parsing the identityResponse, which is where a lot of the additional logic about making a new current user, happens. So we can probably remove the waitForCondition and leave yours.

This can be a future cleanup ticket once we merge everything in, but at the bottom of the parseIdentityResponse, we do log Successfully parsed Identity Response. I wonder if we should be mocking the logger and waiting for this to be called and then this will basically allow us to know that an identity has been fully returned AND completely parsed.

rmi22186 · 2025-10-25T03:08:11Z

test/src/tests-identities-attributes.ts

                mParticle.getInstance()._Store.identityCallInFlight === false
            );
        });
-        // switching back to logged in user should not result in any UIC events


let's keep this comment

rmi22186 · 2025-10-25T03:10:39Z

test/src/tests-identity.ts

            mParticle.init(apiKey, window.mParticle.config);

-            await waitForCondition(hasIdentityCallInflightReturned)
+            await waitForCondition(hasIdentityCallInflightReturned);            


Suggested change

await waitForCondition(hasIdentityCallInflightReturned);

await waitForCondition(hasIdentityCallInflightReturned);

…o test/SDKE-399-evaluate-identity-related-tests

…ests

rmi22186 · 2025-10-28T16:11:18Z

test/src/config/utils.js

+    hasIdentityResponseParsed = (loggerSpy) => {
+        return () => loggerSpy?.verbose?.getCalls()?.some(call => 
+            call.args[0] === 'Successfully parsed Identity Response'
+        ) || false;


the || false here is unnecessary since the .some() already returns a boolean

Suggested change

) || false;

);

rmi22186 · 2025-10-28T17:46:26Z

test/src/tests-identities-attributes.ts

-
+        fetchMock.resetHistory();
+        // Clear out before each init call
+        await waitForCondition(hasBeforeEachCallbackReturned);


If you add await waitForCondition anywhere in this file, I'd suggest adding it above resetForTests in the same codeblock

Yeah, totally makes sense since we're checking if the beforeEach init has completed before resetting. Updated for all occurrences in the code.

rmi22186 · 2025-10-28T18:00:16Z

test/src/tests-identity.ts

+        await waitForCondition(hasIdentityCallInflightReturned);
+        await waitForCondition(hasLoginReturned);


i think this can be just

Suggested change

await waitForCondition(hasIdentityCallInflightReturned);

await waitForCondition(hasLoginReturned);

await waitForCondition(hasIdentityResponseParsed(loggerSpy));

Yes, missed that. Updated the test now.

sonarqubecloud · 2025-10-28T21:02:21Z

Quality Gate failed

Failed conditions
7.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

test: updated setup for identity tests

0b41099

jaissica12 marked this pull request as ready for review October 20, 2025 21:22

jaissica12 requested a review from rmi22186 October 21, 2025 15:48

jaissica12 added 16 commits October 22, 2025 17:48

test: added .only to test files for targeted testing

600d90a

test: updated identity test for failing test

46d2c3b

test: updated identity test to handle identity calls

c0fb30e

test: document Firefox timing issues in identity tests

6e80ee6

test: updated karma timeout config

a4c5c44

test: updated identity tests to resolve flaky tests

f691539

test: updated identity test when mpid is zero

b245b05

test: updated identity tests when mpid is invalid

1eb173b

test: updated karma config for timeout issues

4e4de0b

test: increase timeout for flaky identity tests for Firefox

b2ab345

test: reduce browserNoActivityTimeout to 20000 for Firefox browser

71302f9

test: increase browserNoActivityTimeout to 60000 for Firefox browser

301d5f9

test: increase mocha timeout to 10 seconds

f537ab7

test: updated timeout for identity test

00fad32

test: reverted timeout changes from individual tests

c738b43

test: updated waitForCondition for identity login

01a78d8

rmi22186 reviewed Oct 25, 2025

View reviewed changes

jaissica12 added 5 commits October 27, 2025 09:20

test: cleanup identity tests

62aef29

test: use logger spy for robust identity test SDKE-420

45b9892

Merge branch 'test/SDKE-303-evaluate-each-integration-test-setup' int…

2b49b0a

…o test/SDKE-399-evaluate-identity-related-tests

test: updated failing identities attributes test

cf63920

test: use logger spy for identity response in identity attributes tests

ea95636

jaissica12 added 9 commits October 27, 2025 14:17

test: fix logger spy scope in identity attributes test

e0032c7

test: update logger spy in identity tests

565cec7

test: updated identity callback test to handle timeout error

32e35f3

test: rollback karma config timeout to 5 sec

1dec717

test: update failing identity tests to with logger spy

1dc590e

test: update identity test waitForCondition for modify function

fa332dd

test: rollback karma config and remove SDKE-420 ticket comment

2c02bcd

test: removed extra spaces and waitForCondition calls from identity t…

9c90192

…ests

test: added ticket SDKE-420 comment for flakey test

705e462

jaissica12 requested a review from rmi22186 October 28, 2025 15:49

rmi22186 reviewed Oct 28, 2025

View reviewed changes

jaissica12 added 2 commits October 28, 2025 16:00

test: clean up identity tests and add SDKE-420 comment to flaky tests

7eb53bc

test: updated test message content

088aa6c

jaissica12 requested a review from rmi22186 October 28, 2025 20:28

rmi22186 and others added 2 commits October 28, 2025 16:30

fix test for queue events when MPID is 0

6dea100

test: updated identity localStorage flaky test

acfaa82

		await waitForCondition(hasIdentityCallInflightReturned);
		await waitForCondition(() => {

		await waitForCondition(hasIdentityCallInflightReturned);
		await waitForCondition(hasLoginReturned);

	await waitForCondition(hasIdentityCallInflightReturned);
	await waitForCondition(hasLoginReturned);
	await waitForCondition(hasIdentityResponseParsed(loggerSpy));

Uh oh!

test: updated setup for identity tests #1105

Are you sure you want to change the base?

test: updated setup for identity tests #1105

Uh oh!

Conversation

jaissica12 commented Oct 20, 2025

Background

What Has Changed

Screenshots/Video

Checklist

Additional Notes

Reference Issue (For employees only. Ignore if you are an outside contributor)

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Oct 28, 2025

Quality Gate failed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants