gui: fix custom color support UI rendering issues #2666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artiq/dashboard/experiments.py
Outdated
|
|
||
| def apply_colors(self): | ||
| def apply_color(self, key=None): |
There was a problem hiding this comment.
So the default is not to do anything?
How about breaking this function into two? Most of it is inside that if key ==
|
Generally seems a bit messy. |
artiq/gui/entries.py
Outdated
| @@ -108,7 +135,8 @@ def _get_group(self, key): | |||
| return self._groups[key] | |||
| group = QtWidgets.QTreeWidgetItem([key]) | |||
| for col in range(3): | |||
| group.setBackground(col, self.palette().mid()) | |||
| color = getattr(self, 'group_color', self.palette().mid().color()) | |||
There was a problem hiding this comment.
Something more explicit than this discreetly set group_color attribute would be clearer, more maintainable and less bug-prone.
There was a problem hiding this comment.
In general try to avoid creating new attributes anywhere else than the constructor.
fsagbuya
force-pushed
the
fix_color_ui
branch
from
4620bc1 to
1953295
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARTIQ Pull Request
Description of Changes
Fixes issues with custom color support interfering with normal widget styling:
styleSheetwith palette for consistent widget stylingDefault view on Windows:
Default view on Linux (gradient is lighter in pyqt6)
Colored View on Linux:
Related Issue
Closes #2661
Type of Changes
Steps (Choose relevant, delete irrelevant before submitting)
All Pull Requests
git commit --signoff, see copyright).Code Changes
flake8to check code style (follow PEP-8 style).flake8has issues with parsing Migen/gateware code, ignore as necessary.- Tested on Linux and Windows
Git Logistics
git rebase --interactive). Merge/squash/fixup commits that just fix or amend previous commits. Remove unintended changes & cleanup. See tutorial.git show). Format:Licensing
See copyright & licensing for more info.
ARTIQ files that do not contain a license header are copyrighted by M-Labs Limited and are licensed under LGPLv3+.