This repository has been archived by the owner on Jan 5, 2023. It is now read-only.
Merge from kubeflow/katib #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
meow @vinaykakade |
…tend (#2005) Bumps [socket.io-parser](https://github.com/socketio/socket.io-parser) from 4.0.4 to 4.0.5. - [Release notes](https://github.com/socketio/socket.io-parser/releases) - [Changelog](https://github.com/socketio/socket.io-parser/blob/main/CHANGELOG.md) - [Commits](socketio/socket.io-parser@4.0.4...4.0.5) --- updated-dependencies: - dependency-name: socket.io-parser dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* gh-actions: Extend action to run Frontend Unit tests Extend Frontend Test action to run also KWA frontend unit tests. Signed-off-by: Orfeas Kourkakis <[email protected]> * gh-actions: Exclude actions when there are only UI changes Prevent the following workflows when a PR contains changes that affect only the frontend: - Charmed Katib - E2E Test with darts-cnn-cifar10 - E2E Test with enas-cnn-cifar10 - E2E Test with mxnet-mnist - E2E Test with pytorch-mnist - E2E Test with simple-pbt - E2E Test with tf-mnist-with-summaries - Go Test - Publish AutoML Algorithm Images - Publish Katib Core Images - Publish Trial Images - Python Test - Shellcheck Signed-off-by: Orfeas Kourkakis <[email protected]> * gh-actions: Add action to build Katib UI image. Signed-off-by: Orfeas Kourkakis <[email protected]> Signed-off-by: Orfeas Kourkakis <[email protected]>
…1991) * Introduce the kfp-run component as a distinct component. * Make the pipeline button a link. Signed-off-by: Elena Zioga <[email protected]> Signed-off-by: Elena Zioga <[email protected]>
Fix 500 error when refreshing KWA's detail page by also adding the namespace variable as a query param to the route. Signed-off-by: Elena Zioga <[email protected]> Signed-off-by: Elena Zioga <[email protected]>
…#2012) Bumps [loader-utils](https://github.com/webpack/loader-utils) from 1.4.1 to 1.4.2. - [Release notes](https://github.com/webpack/loader-utils/releases) - [Changelog](https://github.com/webpack/loader-utils/blob/v1.4.2/CHANGELOG.md) - [Commits](webpack/loader-utils@v1.4.1...v1.4.2) --- updated-dependencies: - dependency-name: loader-utils dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Introduce COMMIT file that contains the commit where Katib needs to checkout inside Kubeflow's common code in order to be built. This file was integrated in the following places as well, thus a developer may only update one file each time we need to checkout to a newer commit. - Dockerfile - GH actions - README.md Signed-off-by: Orfeas Kourkakis <[email protected]> Signed-off-by: Orfeas Kourkakis <[email protected]>
) Bumps [loader-utils](https://github.com/webpack/loader-utils) from 2.0.3 to 2.0.4. - [Release notes](https://github.com/webpack/loader-utils/releases) - [Changelog](https://github.com/webpack/loader-utils/blob/v2.0.4/CHANGELOG.md) - [Commits](webpack/loader-utils@v2.0.3...v2.0.4) --- updated-dependencies: - dependency-name: loader-utils dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* kwa(front): Add new Editor component Import new Editor component from Kubeflow Common Library and replace all instances of previous Ace Editor. Signed-off-by: Orfeas Kourkakis <[email protected]> * Update COMMIT file to a more recent one in Kubeflow Signed-off-by: Orfeas Kourkakis <[email protected]> Signed-off-by: Orfeas Kourkakis <[email protected]>
Bumps [minimatch](https://github.com/isaacs/minimatch) from 3.0.4 to 3.1.2. - [Release notes](https://github.com/isaacs/minimatch/releases) - [Commits](isaacs/minimatch@v3.0.4...v3.1.2) --- updated-dependencies: - dependency-name: minimatch dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…/tf-mnist-with-summaries (#2030) Bumps [tensorflow](https://github.com/tensorflow/tensorflow) from 2.9.1 to 2.9.3. - [Release notes](https://github.com/tensorflow/tensorflow/releases) - [Changelog](https://github.com/tensorflow/tensorflow/blob/master/RELEASE.md) - [Commits](tensorflow/tensorflow@v2.9.1...v2.9.3) --- updated-dependencies: - dependency-name: tensorflow dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…/enas-cnn-cifar10 (#2031) Bumps [tensorflow](https://github.com/tensorflow/tensorflow) from 2.9.1 to 2.9.3. - [Release notes](https://github.com/tensorflow/tensorflow/releases) - [Changelog](https://github.com/tensorflow/tensorflow/blob/master/RELEASE.md) - [Commits](tensorflow/tensorflow@v2.9.1...v2.9.3) --- updated-dependencies: - dependency-name: tensorflow dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…2032) Bumps [engine.io](https://github.com/socketio/engine.io) from 6.2.0 to 6.2.1. - [Release notes](https://github.com/socketio/engine.io/releases) - [Changelog](https://github.com/socketio/engine.io/blob/main/CHANGELOG.md) - [Commits](socketio/engine.io@6.2.0...6.2.1) --- updated-dependencies: - dependency-name: engine.io dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…tfevent-metricscollector (#2028) Bumps [tensorflow](https://github.com/tensorflow/tensorflow) from 2.9.1 to 2.9.3. - [Release notes](https://github.com/tensorflow/tensorflow/releases) - [Changelog](https://github.com/tensorflow/tensorflow/blob/master/RELEASE.md) - [Commits](tensorflow/tensorflow@v2.9.1...v2.9.3) --- updated-dependencies: - dependency-name: tensorflow dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* [bugfix] Fix value passing bug in New Experiment form Add missing logic in New Experiment form in order to pass the value of the editor content in Metrics Collector tab, when Kind is set to Custom. * Adjust unit tests for custom yaml metrics collector
* UI(back): Add authorization mechanisms in new Katib UI backend
* Introduce helper ENV vars and functions for authentication and
authorization checks. The authz checks are using SubjectAcessReviews
objects.
* BACKEND_MODE={dev,prod}: skip authz when in dev mode
* APP_DISABLE_AUTH={bool}: skip authz if explicity requested
* Introduce a client-go client to construct SubjectAccessReview objects.
* Before any request proceed to K8s api-server:
* check if authorization must be skipped (BACKEND_MODE, APP_DISBLE_AUTH)
* check if a username is proviced in request Header
* query the K8s api-server with SAR to ensure that the user has
appropriate access privilleges
* Replace the /katib/fetch_experiment/ route with /katib/fetch_namespaces_experiments.
This route expects a namespace as a query parameter from which all experiments will be fetched.
Signed-off-by: Apostolos Gerakaris <[email protected]>
* UI(front): Provide a namespace as a query parameter
This is needed for the new /katib/fetch_namespaced_experiments route.
Signed-off-by: Apostolos Gerakaris <[email protected]>
* Update README for running locally without auth
Update the README of the web app to expose that devs should set
APP_DISABLE_AUTH=true when running locally, since there's no authnz when
running locally.
Signed-off-by: Apostolos Gerakaris <[email protected]>
* remove duplicated variable types
Signed-off-by: Apostolos Gerakaris <[email protected]>
* Review fixes
* proper error handling.
* switch to Go's build-in errors package.
* set appropriate verbs when constructing SAR objects.
Signed-off-by: Apostolos Gerakaris <[email protected]>
* review: Use controller-runtime client to create SAR objects
Signed-off-by: Apostolos Gerakaris <[email protected]>
* Review fixes
* fix backend routes.
* '/katib/fetch_namespaces' to fetch experiments in a namespace
* 'FetchExperiments' handler
* hit the appropriate route from frontend and provide namespace as a
query parameter to fetch experiments
* remove remove BACKEND_MODE env var in
favour of the more specific APP_DISABLE_AUTH
Signed-off-by: Apostolos Gerakaris <[email protected]>
* Review fixes
* Add constants for CRUD actions
* Add plural for experiments and suggestions as constants
* Add GetUsername logic under IsAuthorized and handle errors properly
* Have APP_DISABLE_AUTH by default as true, since currently Katib
doesn't support this feature in standalone mode.
Signed-off-by: Apostolos Gerakaris <[email protected]>
Signed-off-by: Apostolos Gerakaris <[email protected]>
* [Test] Reduce Katib GitHub Action Runs * Add cancel-in-progress flag * Use single job for Charmed Katib * Add cancel-in-progress for all actions except publish * Bump ubuntu to 20.04 for Charmed tests
* frontend: Create a yaml tab for Trials (#2011) * Create a dedicated yaml tab for Trials. Signed-off-by: Elena Zioga <[email protected]> * frontend: Rename components * Rename trial-modal component to trial-details. * Rename trial-modal-overview component to trial-overview. Signed-off-by: Elena Zioga <[email protected]> Signed-off-by: Elena Zioga <[email protected]>
…a1 (#2029) Bumps [tensorflow](https://github.com/tensorflow/tensorflow) from 2.9.1 to 2.9.3. - [Release notes](https://github.com/tensorflow/tensorflow/releases) - [Changelog](https://github.com/tensorflow/tensorflow/blob/master/RELEASE.md) - [Commits](tensorflow/tensorflow@v2.9.1...v2.9.3) --- updated-dependencies: - dependency-name: tensorflow dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: tenzen-y <[email protected]> Signed-off-by: tenzen-y <[email protected]>
* build: Update the COMMIT file * Update the COMMIT file. Signed-off-by: Elena Zioga <[email protected]> * frontend: Support paging/sorting/filtering in trials table (#1441) * Make trials table support paging, sorting and filtering. Signed-off-by: Elena Zioga <[email protected]> * frontend: Create unit tests for trials table (#1441) * Create unit tests for trials-table component. Signed-off-by: Elena Zioga <[email protected]> Signed-off-by: Elena Zioga <[email protected]>
* frontend: Remove TSLint Remove TSLint since it's deprecated. Signed-off-by: Elena Zioga <[email protected]> * frontend: Introduce ESLint Introduce ESLint by using the following Angular command [1]: ng add @angular-eslint/schematics [1] https://github.com/angular-eslint/angular-eslint#quick-start-with-angular-v12-and-later Signed-off-by: Elena Zioga <[email protected]> * frontend: Fix linting errors Fix linting errors. Signed-off-by: Elena Zioga <[email protected]> * gh-actions: Add GH action to run a lint check Introduce a Github action to run a lint check. Signed-off-by: Elena Zioga <[email protected]> Signed-off-by: Elena Zioga <[email protected]>
…2033) * Show the successful trials in the experiment graph. Signed-off-by: Elena Zioga <[email protected]> Signed-off-by: Elena Zioga <[email protected]>
* add early stopped trials in converter * error out early * Update pkg/suggestion/v1beta1/internal/trial.py Co-authored-by: Yuki Iwai <[email protected]> * add incomplete trial filter * fix ut * more fixes * filter on es * enrich existing tests Co-authored-by: shaowei su <[email protected]> Co-authored-by: Yuki Iwai <[email protected]>
* Remove Certificate Chain from Cert Generator * Update Cert Generator Doc
Signed-off-by: Andrey Velichkevich <[email protected]>
Signed-off-by: Andrey Velichkevich <[email protected]>
Signed-off-by: Gonçalo Montalvão Marques <[email protected]>
Bumps [github.com/golang-jwt/jwt/v4](https://github.com/golang-jwt/jwt) from 4.5.0 to 4.5.1. - [Release notes](https://github.com/golang-jwt/jwt/releases) - [Changelog](https://github.com/golang-jwt/jwt/blob/main/VERSION_HISTORY.md) - [Commits](golang-jwt/jwt@v4.5.0...v4.5.1) --- updated-dependencies: - dependency-name: github.com/golang-jwt/jwt/v4 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Andrey Velichkevich <[email protected]>
Signed-off-by: Electronic-Waste <[email protected]>
* fix: fix the broken link. Signed-off-by: Electronic-Waste <[email protected]> * fix(doc): update guidance in multi-users pipelines setup. Signed-off-by: Electronic-Waste <[email protected]> --------- Signed-off-by: Electronic-Waste <[email protected]>
Signed-off-by: tariq-hasan <[email protected]>
* fix(ui): update None Collector with Push Collector. Signed-off-by: Electronic-Waste <[email protected]> * fix(ui): replace some remaining None MC. Signed-off-by: Electronic-Waste <[email protected]> --------- Signed-off-by: Electronic-Waste <[email protected]>
…sal directory and rename it (#2472) - remove redundant folder Signed-off-by: mahdikhashan <[email protected]>
* chore: update go.mod & go mod tidy. Signed-off-by: Electronic-Waste <[email protected]> * chore: replace source.Kind and EnqueueRequestForXxx with typed func call. Signed-off-by: Electronic-Waste <[email protected]> * chore: update admission.Decoder in webhook. Signed-off-by: Electronic-Waste <[email protected]> * chore: update Makefile. Signed-off-by: Electronic-Waste <[email protected]> * fix: update codegen script. Signed-off-by: Electronic-Waste <[email protected]> * chore: execute update-codegen.sh. Signed-off-by: Electronic-Waste <[email protected]> * chore: update openapigen & generate new openapi definitions. Signed-off-by: Electronic-Waste <[email protected]> * fix: fix typo error. Signed-off-by: Electronic-Waste <[email protected]> * chore: update k8s version in CI. Signed-off-by: Electronic-Waste <[email protected]> * test(codegen): output CODEGEN_PKG. Signed-off-by: Electronic-Waste <[email protected]> * fix(codegen): move shell check annotation. Signed-off-by: Electronic-Waste <[email protected]> * fix(ci): change k8s version in go test to 1.30.0. Signed-off-by: Electronic-Waste <[email protected]> * fix: remove toolchain declaration in go.mod Signed-off-by: Electronic-Waste <[email protected]> * fix: remove codegen dependency in openapigen.sh. Signed-off-by: Electronic-Waste <[email protected]> * fix: fix bugs in recursive dir detection. Signed-off-by: Electronic-Waste <[email protected]> * fix: remove a blank line. Signed-off-by: Electronic-Waste <[email protected]> * fix: remove klog/v2 Signed-off-by: Electronic-Waste <[email protected]> * chore(codegen): add three dots in the comment. Signed-off-by: Electronic-Waste <[email protected]> * fix(codegen): fix package dependency on k8s.io/code-generator. Signed-off-by: Electronic-Waste <[email protected]> * chore(Makefile): add go-mod-download. Signed-off-by: Electronic-Waste <[email protected]> --------- Signed-off-by: Electronic-Waste <[email protected]>
Signed-off-by: Electronic-Waste <[email protected]>
* chore(ci): add k8s version 1.31. Signed-off-by: Electronic-Waste <[email protected]> * chore(Makefile): upgrade envtest version to 1.31 & setup-envtest to release-0.19. Signed-off-by: Electronic-Waste <[email protected]> * chore: update k8s related package in go.mod Signed-off-by: Electronic-Waste <[email protected]> * chore: make generate. Signed-off-by: Electronic-Waste <[email protected]> * fix(test): add SkipNameValidation option to test frame. Signed-off-by: Electronic-Waste <[email protected]> * refactor(grpc): remove deprecated grpc.Dial implementation. Signed-off-by: Electronic-Waste <[email protected]> * fix(dependency): remove dependency on k8s v1.28 Signed-off-by: Electronic-Waste <[email protected]> * fix: add type assertion to ptr.To Signed-off-by: Electronic-Waste <[email protected]> --------- Signed-off-by: Electronic-Waste <[email protected]>
Signed-off-by: Electronic-Waste <[email protected]>
Signed-off-by: Xinmin Du <[email protected]>
Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.21.0 to 0.31.0. - [Commits](golang/crypto@v0.21.0...v0.31.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Upgrade klog dependency to v2 Signed-off-by: Xinmin Du <[email protected]> Signed-off-by: Xinmin Du <[email protected]> * fix: fix conflict with k8s upate Signed-off-by: Xinmin Du <[email protected]> --------- Signed-off-by: Xinmin Du <[email protected]> Signed-off-by: Xinmin Du <[email protected]> Signed-off-by: Du Xinmin <[email protected]> Co-authored-by: Xinmin Du <[email protected]>
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.27.0 to 0.33.0. - [Commits](golang/net@v0.27.0...v0.33.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: truc0 <[email protected]>
Signed-off-by: Caio Almeida <[email protected]>
…missionWebhookMatchConditions (#2241) Signed-off-by: lianghao208 <[email protected]>
Bumps [express](https://github.com/expressjs/express) from 4.19.2 to 4.21.2. - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/4.21.2/History.md) - [Commits](expressjs/express@4.19.2...4.21.2) --- updated-dependencies: - dependency-name: express dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [axios](https://github.com/axios/axios) from 1.7.2 to 1.7.9. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md) - [Commits](axios/axios@v1.7.2...v1.7.9) --- updated-dependencies: - dependency-name: axios dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* fix tune api error Signed-off-by: helenxie-bit <[email protected]> * delete check for Signed-off-by: helenxie-bit <[email protected]> --------- Signed-off-by: helenxie-bit <[email protected]>
* add unit tests for tune api Signed-off-by: helenxie-bit <[email protected]> * update Signed-off-by: helenxie-bit <[email protected]> * fix format Signed-off-by: helenxie-bit <[email protected]> * update unit tests and fix api errors Signed-off-by: helenxie-bit <[email protected]> * fix format Signed-off-by: helenxie-bit <[email protected]> * test Signed-off-by: helenxie-bit <[email protected]> * test Signed-off-by: helenxie-bit <[email protected]> * update unit tests Signed-off-by: helenxie-bit <[email protected]> * undo changes to Makefile Signed-off-by: helenxie-bit <[email protected]> * delete debug code Signed-off-by: helenxie-bit <[email protected]> * fix format Signed-off-by: helenxie-bit <[email protected]> * update unit test Signed-off-by: helenxie-bit <[email protected]> * fix format Signed-off-by: helenxie-bit <[email protected]> * update the version of training operator Signed-off-by: helenxie-bit <[email protected]> * adjust 'list_namespaced_persistent_volume_claim' to be called with keyword argument Signed-off-by: helenxie-bit <[email protected]> * create constant for namespace when check pvc creation error Signed-off-by: helenxie-bit <[email protected]> * add type check for 'trainer_parameters' Signed-off-by: helenxie-bit <[email protected]> * fix format Signed-off-by: helenxie-bit <[email protected]> * update test names Signed-off-by: helenxie-bit <[email protected]> * fix format Signed-off-by: helenxie-bit <[email protected]> * add verification for key Experiment information & add 'kubeflow-training[huggingface' into dependencies Signed-off-by: helenxie-bit <[email protected]> * rerun tests Signed-off-by: helenxie-bit <[email protected]> * add verification for objective metric name Signed-off-by: helenxie-bit <[email protected]> * delete unnecessary changes Signed-off-by: helenxie-bit <[email protected]> * unify objective function Signed-off-by: helenxie-bit <[email protected]> * unify objective function Signed-off-by: helenxie-bit <[email protected]> --------- Signed-off-by: helenxie-bit <[email protected]>
…2498) * Sort experiments by descending creation date by default in katib-ui Signed-off-by: Xinmin Du <[email protected]> * fix: Update "renders every Experiment name into the table" test to not check order Signed-off-by: Xinmin Du <[email protected]> * fix: Update "renders every Experiment name into the table" test in order of startTime Signed-off-by: Xinmin Du <[email protected]> --------- Signed-off-by: Xinmin Du <[email protected]>
* improve pvc name error message by failing early and clear message with correct name example Signed-off-by: mahdikhashan <[email protected]> * fix lint Signed-off-by: mahdikhashan <[email protected]> * fix lint Signed-off-by: mahdikhashan <[email protected]> * raise value error for wrong name format by reconciliation Signed-off-by: mahdikhashan <[email protected]> * revert created utils Signed-off-by: mahdikhashan <[email protected]> * improve test case name Signed-off-by: mahdikhashan <[email protected]> * improve value error message Signed-off-by: mahdikhashan <[email protected]> * improve code flow Signed-off-by: mahdikhashan <[email protected]> --------- Signed-off-by: mahdikhashan <[email protected]>
…ion (#2437) Signed-off-by: Electronic-Waste <[email protected]>
* update the version of typing-extensions Signed-off-by: helenxie-bit <[email protected]> * update comment Signed-off-by: helenxie-bit <[email protected]> --------- Signed-off-by: helenxie-bit <[email protected]>
* resolved merge conflicts Signed-off-by: Shashank Mittal <[email protected]> * fix Signed-off-by: Shashank Mittal <[email protected]> * DISTRIBUTION_UNKNOWN enum set to 0 in gRPC api Signed-off-by: Shashank Mittal <[email protected]> * convert parameter method fix Signed-off-by: Shashank Mittal <[email protected]> validation fix add e2e tests for hyperopt added e2e test to workflow * convert feasibleSpace func updated Signed-off-by: Shashank Mittal <[email protected]> * renamed DISTRIBUTION_UNKNOWN to DISTRIBUTION_UNSPECIFIED Signed-off-by: Shashank Mittal <[email protected]> * fix Signed-off-by: Shashank Mittal <[email protected]> * added more test cases for hyperopt distributions Signed-off-by: Shashank Mittal <[email protected]> * added support for NORMAL and LOG_NORMAL in hyperopt suggestion service Signed-off-by: Shashank Mittal <[email protected]> * added e2e tests for NORMAL and LOG_NORMAL Signed-off-by: Shashank Mittal <[email protected]> sigma calculation fixed fix parse new arguments to mnist.py * hyperopt-suggestion example update Signed-off-by: Shashank Mittal <[email protected]> * updated logic for log distributions Signed-off-by: Shashank Mittal <[email protected]> * updated logic for log distributions Signed-off-by: Shashank Mittal <[email protected]> * e2e test fixed Signed-off-by: Shashank Mittal <[email protected]> * added support for parameter distributions for Parameter type INT Signed-off-by: Shashank Mittal <[email protected]> * unit test fixed Signed-off-by: Shashank Mittal <[email protected]> * Update pkg/suggestion/v1beta1/hyperopt/base_service.py Co-authored-by: Yuki Iwai <[email protected]> Signed-off-by: Shashank Mittal <[email protected]> * comment fixed Signed-off-by: Shashank Mittal <[email protected]> * added unit tests for INT parameter type Signed-off-by: Shashank Mittal <[email protected]> * completed param unit test cases Signed-off-by: Shashank Mittal <[email protected]> * handled default case for normal distributions when min or max are not specified Signed-off-by: Shashank Mittal <[email protected]> * fixed validation logic for min and max Signed-off-by: Shashank Mittal <[email protected]> * removed unnecessary test params Signed-off-by: Shashank Mittal <[email protected]> * fixes Signed-off-by: Shashank Mittal <[email protected]> * added comments Signed-off-by: Shashank Mittal <[email protected]> * fix Signed-off-by: Shashank Mittal <[email protected]> * set default distribution as uniform Signed-off-by: Shashank Mittal <[email protected]> * line omit Signed-off-by: Shashank Mittal <[email protected]> * removed empty spaces from yaml files Signed-off-by: Shashank Mittal <[email protected]> --------- Signed-off-by: Shashank Mittal <[email protected]> Co-authored-by: Yuki Iwai <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.