Skip to content

Conversation

agaida
Copy link
Member

@agaida agaida commented Jan 1, 2019

refs lxqt/lxqt/issues/1583

It will wreck the WM logic if openbox is not installed, the dialog will appear,
even if not needed.

refs lxqt/lxqt/issues/1583

It will wreck the WM logic if openbox is not installed, the dialog will appear,
even if not needed.
@agaida
Copy link
Member Author

agaida commented Jan 1, 2019

Just tested, works fine as long only one WM is installed (and in the list)

it was fucking ugly (really) and not readable. 600x400 should work fine even
on ancient devices with 1024x600
@agaida
Copy link
Member Author

agaida commented Jan 1, 2019

@palinek @tsujan - this PR should solve the most of our WM-select problems for now. Maybe we should improve later, but right now i don't see any need to do so.

@tsujan
Copy link
Member

tsujan commented Jan 1, 2019

I don't have openbox but I do have kwin and cannot uninstall it to test this. Could you test what happens if no LXQt-compatible WM is installed? Theoretically, the dialog should be shown.

@agaida
Copy link
Member Author

agaida commented Jan 1, 2019

i can't test - i put all WMs available into our list, that means i had to deinstall all WMs - upps, dependency conflict.

For Debian this is a non-issue because of the dependency xfwm4|x-window-manager - so the case can't happend.

@agaida
Copy link
Member Author

agaida commented Jan 1, 2019

What can/will happend is that the user has more than one WM installed and non configured - so the Dialog will appear. But the dialog is now more readable and more complete because of our extended list - i would leave it like it is right now, removing the preconfigured openbox in session.conf was the culprit as @palinek mentioned.

@agaida
Copy link
Member Author

agaida commented Jan 1, 2019

just tested with cinnamon in a fresh VM - after installing cinnamon only updated and

apt install lxqt openbox

Result at first start:

@palinek - we have no WM at this point - so if we want to have a 'Cancel'-Button - what to do? Using the first WM found?

@palinek
Copy link
Contributor

palinek commented Jan 2, 2019

@palinek - we have no WM at this point - so if we want to have a 'Cancel'-Button - what to do?

What is wrong with #181?

@agaida
Copy link
Member Author

agaida commented Jan 2, 2019

@palinek - good question, will test again. Last time i test it it does nothing - might be my fault.

@agaida
Copy link
Member Author

agaida commented Jan 2, 2019

@palinek @tsujan - the code itself looks promising, but it seems that something is wrong with the button - no clue what.

@agaida agaida merged commit d957606 into master Jan 20, 2019
@yan12125 yan12125 deleted the not-default-on-openbox branch August 10, 2021 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants