Skip to content

Conversation

@isf63
Copy link
Contributor

@isf63 isf63 commented May 19, 2025

Previously the menu action for emptying, inside the trash:/// folder, disappeared when there was nothing to empty.

This makes the menu consistent with Desktop and 'Places' menus, which instead greyed the action. It also in my opinion is better UX.

To test

  1. PCManFM-Qt → Places → Trash → Right click
  2. PCManFM-Qt Desktop → Trash → Right click
  3. PCManFM-Qt trash:/// → Right click

Previously the menu action disappeared when there was nothing to empty.

This makes the menu consistent with Desktop and 'Places' menus, which
instead greyed the action.
@tsujan
Copy link
Member

tsujan commented May 19, 2025

I made it so intentionally :)

It also in my opinion is better UX.

I'm afraid I disagree.

@isf63
Copy link
Contributor Author

isf63 commented May 19, 2025

Why intentionally?

It's much better IMO if menus are static, and the disabled cue is everywhere but folder view.

@tsujan
Copy link
Member

tsujan commented May 19, 2025

Why intentionally?

Didn't want a redundant item there. The context menu may already be populated by custom actions of all kinds. I know yours isn't, but it's a possibility. The less redundant items, the better.

It's much better IMO…

Much?! Sometimes I wonder why you exaggerate :) Although I like it when you pay attention to details.

@isf63
Copy link
Contributor Author

isf63 commented May 19, 2025

Ha, it is a minor detail, there is not much about anything.

Personally I think having a static menu (important items are the same, only enabled/disabled) + consistency with other locations, is worth one extra menu item in the case of an empty Trash folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants