boards: add linux-based supported boards #105
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 3 files
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.
<file name="boards/renesas/rz-g3e-evkit/README.md">
<violation number="1" location="boards/renesas/rz-g3e-evkit/README.md:117">
The sample CMake command selects `-DCONFIG=drm-egl`, but the repo only ships `drm-egl-2d.defaults`, so following these instructions fails to configure the build. Please update the command to use the available `drm-egl-2d` config.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
| The SDK includes `cmake` and `ninja` so you don't need to install them. | ||
|
|
||
| ```shell | ||
| cmake -B build -DCONFIG=drm-egl -GNinja |
There was a problem hiding this comment.
The sample CMake command selects -DCONFIG=drm-egl, but the repo only ships drm-egl-2d.defaults, so following these instructions fails to configure the build. Please update the command to use the available drm-egl-2d config.
Prompt for AI agents
Address the following comment on boards/renesas/rz-g3e-evkit/README.md at line 117:
<comment>The sample CMake command selects `-DCONFIG=drm-egl`, but the repo only ships `drm-egl-2d.defaults`, so following these instructions fails to configure the build. Please update the command to use the available `drm-egl-2d` config.</comment>
<file context>
@@ -0,0 +1,160 @@
+ The SDK includes `cmake` and `ninja` so you don't need to install them.
+
+ ```shell
+ cmake -B build -DCONFIG=drm-egl -GNinja
+ ```
+- Edit `src/main.c` if you want to change the default demo.
</file context>
Suggested change
| cmake -B build -DCONFIG=drm-egl -GNinja | |
| cmake -B build -DCONFIG=drm-egl-2d -GNinja |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Added Renesas RZ/G3E-EVKIT as a supported Linux board with setup, build, and run docs, plus a manifest to use drm-egl-2d defaults. Includes benchmark results and the official quick start guide.