Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements #1

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

Improvements #1

wants to merge 22 commits into from

Conversation

aorin
Copy link
Contributor

@aorin aorin commented Mar 10, 2025

This contains various improvements, those mentioned in the luomus/laji#751 issue and some extra. Here is the list of the changes:

  1. Updated all dependencies. Also replaced deprecated requests with axios and http-proxy-middleware.
  2. Added eslint and some tests
  3. The backend will return a 401 response with a message Login Required if the frontend tries to access an /api/ route and the authentication has expired.
  4. Query hash checking is removed from graphql queries
  5. Helmet's content security policy is disabled since maintaining allowedResourceSources has proven to be challenging and has caused problems

aorin added 22 commits February 25, 2025 13:57
@aorin
remove unused code, fix organization service types
8807a60
@aorin
remove unused e2e tests
943a3f8
@aorin
update dependencies
1668746
@aorin
remove helmet
8814aea
@aorin
add eslint
b0fba37
@aorin
allow all graphql queries
bce1153
@aorin
return error message when authentication fails
fb042b9
@aorin
fix app requiring login on page refresh, don't require authentication…
9d3d91b 
… for static files
@aorin
downgrade node-fetch version for now
5f42f03
@aorin
change output from commonjs to esm
95934d6
@aorin
add helmet back with contentSecurityPolicy disabled
09d00d8
@aorin
add link to the wiki
392b28e
@aorin
laji-auth proxy returns the same status code
e5f1798
@aorin
refactor by moving organization endpoints to a new controller
3dd775c
@aorin
small refactoring
6b5b0eb
@aorin
simplify the organization controller, no need to check the token
9a631a7
@aorin
replace request with axios and http-proxy-middleware
37aa789
@aorin
replace deprecated dependencies
00938de
@aorin
remove unnecessary file
2cc7f5e
@aorin
add tests
1e62427
@aorin
fix logout requests don't log the user id
c2c09b2
@aorin
redirect all unauthenticated frontend requests to login since it does…
cc60422 
…n't cause unnecessary redirects with firefox anymore
@aorin aorin mentioned this pull request Mar 10, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aorin