docs: add HvProvider to the Controls section #4871
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plagoa
requested review from
zettca and
francisco-guilherme
and removed request for
a team
There was a problem hiding this comment.
Pull Request Overview
This PR moves the DocsProvider wrapper from only covering the preview area to encompass both the preview and controls sections. This change ensures that controls like HvColorPicker can access the correct theme colors through the provider context.
- Restructured the layout to wrap both preview and controls sections with
DocsProvider - Added background styling to the controls area for visual consistency
- Maintained the existing grid layout structure
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
francisco-guilherme
approved these changes
Sep 3, 2025
francisco-guilherme
added a commit
that referenced
this pull request
Sep 11, 2025
* docs: add HvProvider to the Controls section * Update apps/docs/src/components/code/Playground.tsx Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: francisco-guilherme <[email protected]> Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We originally left the playground controls section out of the inner
HvProviderbut in reality we need it there as some of the controls (theHvColorPicker) depend on it to get the correct colors.