Improvements to satisfy code checker.

lucaboesch · Jan 19, 2024 · 1b49466 · 1b49466
1 parent 93d709b
commit 1b49466
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/classes/feedback/section.php b/classes/feedback/section.php
@@ -16,6 +16,8 @@
 
 namespace mod_questionnaire\feedback;
 
+defined('MOODLE_INTERNAL') || die();
+
 use invalid_parameter_exception;
 use coding_exception;
 

diff --git a/classes/responsetype/file.php b/classes/responsetype/file.php
@@ -302,7 +302,7 @@ public function get_results_tags($weights, $participants, $respondents, $showtot
                 $file = $fs->get_file_by_id($row->fileid);
 
                 if ($file) {
-                // There is a file.
+                    // There is a file.
                     $imageurl = moodle_url::make_pluginfile_url(
                         $file->get_contextid(),
                         $file->get_component(),

diff --git a/db/upgrade.php b/db/upgrade.php
@@ -1031,7 +1031,7 @@ function xmldb_questionnaire_upgrade($oldversion=0) {
     }
 
     if ($oldversion < 2023101501) {
-        // Upgrade files.itemid with questionnaire_response_file.id
+        // Upgrade files.itemid with questionnaire_response_file.id.
         $filesresponses = $DB->get_records('questionnaire_response_file', [], '', 'id,fileid');
         $idmap = [];
         foreach ($filesresponses as $fileresponse) {