Skip to content

Conversation

@karl-police
Copy link
Contributor

@karl-police karl-police commented Jul 22, 2025

Rendered

is("class")
ìs("extern")

Copy link
Collaborator

@andyfriesen andyfriesen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me!

@karl-police
Copy link
Contributor Author

Sounds good to me!

I made luau-lang/luau#1926 and luau-lang/luau#1927

two variations

@karl-police
Copy link
Contributor Author

It turns out that ìs("class") is actually not used anywhere in the Unit Tests in the first place as well. I could remove Debug infront of the flag and let it turn on through --fflags=true, and allow that all current is("class") will just error.
Unless it's worth to wait and implement a warning that points out to use "extern"

@aatxe
Copy link
Contributor

aatxe commented Aug 21, 2025

It's still a feature in the beta, and not usable elsewhere, and it will never break running code, so I think it's fine for us to not try to manage an awkward "warn to migrate" period (which is, intrinsically, the same as producing the error anyway).

@aatxe aatxe merged commit 84b856a into luau-lang:master Aug 21, 2025
@karl-police karl-police deleted the patch-4 branch August 21, 2025 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants