[no sq] Changes #70
Merged
[no sq] Changes #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sfan5
commented
Feb 13, 2025
sfan5
commented
As discussed internally there are some edge cases where this would require unreasonable changes on the server owner's part
SmallJoker
approved these changes
Feb 13, 2025
| @@ -567,6 +588,13 @@ def get(self, ip, port): | |||
| i, server = self.getWithIndex(ip, port) | |||
| return server | |||
|
|
|||
| def checkDuplicate(self, other_server): | |||
There was a problem hiding this comment.
isDuplicate would be a more accurate name, which is unfortunately lexically similar to is_duplicate.
There was a problem hiding this comment.
I prefer check here for reasons I can't really explain.
ShadowNinja
reviewed
Feb 15, 2025
| server.verifyLevel = 1 | ||
|
|
||
| # do this here since verifyLevel is now set | ||
| if serverList.checkDuplicate(server): |
There was a problem hiding this comment.
This only returns true if it's a duplicate of a different server and that server is more trusted, so maybe this should be named something like isImpersonation instead.
There was a problem hiding this comment.
calling this "impersonation" feels heavy-handed when there are innocent reasons for this to happen, dunno
sfan5
force-pushed
the
chungus
branch
3 times, most recently
from
fb3fb15 to
777ad8d
Compare
|
Now running in production. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.