Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fix pre commit #24

Merged
merged 6 commits into from
Apr 25, 2024
Merged

Build fix pre commit #24

merged 6 commits into from
Apr 25, 2024

Conversation

martibosch
Copy link
Collaborator

@martibosch martibosch commented Apr 24, 2024

Prework

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Documentation
  • Tutorial
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and communicate accordingly:

The PR fulfills these requirements:

  • It's submitted to the branch named as follow:
    • Fix a bug: bugfix-<some_key>-<word>
    • Improve the doc: doc-<some_key>-<word>
    • Improve a tutorial tutorial-<some_key>-<word>
    • Add a new feature: feature-<some_key>-<word>
    • Refactor some code: refactor-<some_key>-<word>
    • Optimize some code: optimize-<some_key>-<word>
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • Don't forget to link PR to issue if you are solving one.
  • All tests are passing.
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Related GitHub issues and pull requests

  • Ref: #

Summary

Please explain the purpose and scope of your contribution.

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 23.37%. Comparing base (718714f) to head (db5229d).
Report is 2 commits behind head on main.

Files Patch % Lines
tstore/archive/attributes/pyarrow.py 0.00% 1 Missing ⚠️
tstore/archive/checks.py 0.00% 1 Missing ⚠️
tstore/archive/ts/utility.py 0.00% 1 Missing ⚠️
tstore/tsdf/extensions/array.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #24   +/-   ##
=======================================
  Coverage   23.37%   23.37%           
=======================================
  Files          37       37           
  Lines         663      663           
=======================================
  Hits          155      155           
  Misses        508      508           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sphamba sphamba merged commit 7481cb8 into main Apr 25, 2024
25 of 26 checks passed
@sphamba sphamba deleted the build-fix-pre-commit branch April 25, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants