Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optional static vars #23

Merged
merged 1 commit into from
Apr 25, 2024
Merged

feat: optional static vars #23

merged 1 commit into from
Apr 25, 2024

Conversation

martibosch
Copy link
Collaborator

@martibosch martibosch commented Apr 23, 2024

Prework

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Documentation
  • Tutorial
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and communicate accordingly:

The PR fulfills these requirements:

  • It's submitted to the branch named as follow:
    • Fix a bug: bugfix-<some_key>-<word>
    • Improve the doc: doc-<some_key>-<word>
    • Improve a tutorial tutorial-<some_key>-<word>
    • Add a new feature: feature-<some_key>-<word>
    • Refactor some code: refactor-<some_key>-<word>
    • Optimize some code: optimize-<some_key>-<word>
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • Don't forget to link PR to issue if you are solving one.
  • All tests are passing.
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Related GitHub issues and pull requests

  • Ref: #

Summary

Please explain the purpose and scope of your contribution.

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 23.23%. Comparing base (7481cb8) to head (eec8893).

Files Patch % Lines
tstore/tslong/pandas.py 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #23      +/-   ##
==========================================
- Coverage   23.37%   23.23%   -0.15%     
==========================================
  Files          37       37              
  Lines         663      667       +4     
==========================================
  Hits          155      155              
- Misses        508      512       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martibosch martibosch force-pushed the feat-optional-static-vars branch from ba8ca20 to 1feb60c Compare April 25, 2024 08:54
@martibosch martibosch force-pushed the feat-optional-static-vars branch from 4e5be0c to eec8893 Compare April 25, 2024 09:38
@martibosch martibosch merged commit 83b50c0 into main Apr 25, 2024
22 of 26 checks passed
@martibosch martibosch deleted the feat-optional-static-vars branch April 25, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants