Make precommit quasi happy

ltelab · Apr 9, 2024 · 5cc5e68 · 5cc5e68
1 parent 96fcb07
commit 5cc5e68
Show file tree

Hide file tree

Showing 9 changed files with 23 additions and 22 deletions.
diff --git a/tstore/archive/io.py b/tstore/archive/io.py
@@ -78,10 +78,7 @@ def get_partitions(base_dir, ts_variable):
 
     metadata = read_tstore_metadata(base_dir=base_dir)
     partitioning = metadata["partitioning"][ts_variable]
-    if partitioning is not None:
-        partitions = partitioning.split("/")
-    else:
-        partitions = []
+    partitions = partitioning.split("/") if partitioning is not None else []
     return partitions
 
 

diff --git a/tstore/archive/metadata/writers.py b/tstore/archive/metadata/writers.py
@@ -1,6 +1,6 @@
 #!/usr/bin/env python3
 """
-Created on Mon Apr  8 17:24:09 2024
+Created on Mon Apr  8 17:24:09 2024.
 
 @author: ghiggi
 """

diff --git a/tstore/archive/partitions.py b/tstore/archive/partitions.py
@@ -1,6 +1,6 @@
 #!/usr/bin/env python3
 """
-Created on Mon Apr  8 17:05:26 2024
+Created on Mon Apr  8 17:05:26 2024.
 
 @author: ghiggi
 """
@@ -44,10 +44,15 @@ def get_partitioning_mapping_dict(time_var, backend="pandas"):
 
 
 def get_valid_partitions():
+    """Get valid partitioning components."""
     return list(get_partitioning_mapping_dict(time_var="dummy"))
 
 
 def check_partitions(partitioning_str):
+    """Check partitioning components of partitinoning string.
+
+    Return the partitioning components.
+    """
     if partitioning_str is None:
         return None
 

diff --git a/tstore/archive/ts/utility.py b/tstore/archive/ts/utility.py
@@ -1,6 +1,6 @@
 #!/usr/bin/env python3
 """
-Created on Mon Apr  8 16:31:23 2024
+Created on Mon Apr  8 16:31:23 2024.
 
 @author: ghiggi
 """

diff --git a/tstore/archive/ts/writers/pyarrow.py b/tstore/archive/ts/writers/pyarrow.py
@@ -1,6 +1,6 @@
 #!/usr/bin/env python3
 """
-Created on Mon Apr  8 17:26:02 2024
+Created on Mon Apr  8 17:26:02 2024.
 
 @author: ghiggi
 """

diff --git a/tstore/tests/test_dummy.py b/tstore/tests/test_dummy.py
@@ -1,6 +1,6 @@
 #!/usr/bin/env python3
 """
-Created on Sun Apr  7 11:04:41 2024
+Created on Sun Apr  7 11:04:41 2024.
 
 @author: ghiggi
 """

diff --git a/tstore/tslong/pandas.py b/tstore/tslong/pandas.py
@@ -66,9 +66,7 @@ def to_tstore(
     tstore_structure="id-var",
     overwrite=True,
 ):
-    """
-    TSLONG.to_tstore()
-    """
+    """TSLONG.to_tstore()."""
     # If index time, remove
     df = df.reset_index(names=time_var)
 
@@ -97,7 +95,7 @@ def to_tstore(
     # - TODO: add flag to check if are actual duplicates !
     df_attrs = df[[id_var, *static_variables]]
     df_attrs = df_attrs.drop_duplicates(subset=id_var)
-    df_attrs.reset_index(drop=True, inplace=True)
+    df_attrs = df_attrs.reset_index(drop=True)
 
     # Write static attributes
     # --> Need to test that save id_var as large_string !
@@ -128,8 +126,8 @@ def to_tstore(
                 columns = [ts_variable]
 
             # Retrieve TS object
-            df_ts = df_group[columns + [time_var]].copy()
-            df_ts.reset_index(drop=True, inplace=True)
+            df_ts = df_group[[*columns, time_var]].copy()
+            df_ts = df_ts.reset_index(drop=True)
 
             # Check time is sorted ?
             # TODO

diff --git a/tstore/tslong/polars.py b/tstore/tslong/polars.py
@@ -1,3 +1,5 @@
+"""TSLONG Polars implementation."""
+
 import pandas as pd
 import polars as pl
 
@@ -60,9 +62,7 @@ def to_tstore(
     tstore_structure="id-var",
     overwrite=True,
 ):
-    """
-    TSLONG.to_tstore()
-    """
+    """TSLONG.to_tstore()."""
     # Check inputs
     tstore_structure = check_tstore_structure(tstore_structure)
     base_dir = check_tstore_directory(base_dir, overwrite=overwrite)
@@ -77,7 +77,7 @@ def to_tstore(
     # Check which columns remains (not specified at class init)
     # TODO
 
-    # Checck partitioning
+    # Check partitioning
     partitioning = check_partitioning(partitioning, ts_variables=list(ts_variables))
 
     # Identify static dataframe (attributes)
@@ -120,12 +120,12 @@ def to_tstore(
                 columns = [ts_variable]
 
             # Retrieve TS object
-            df_ts = df_group[columns + [time_var]]
+            df_ts = df_group[[*columns, time_var]]
 
             # Check time is sorted ?
             # TODO
 
-            # Add partioning columns
+            # Add partitioning columns
             partitioning_str = partitioning[ts_variable]
             df_ts, partitions = add_partitioning_columns(
                 df_ts,
@@ -142,6 +142,7 @@ def to_tstore(
                 tstore_structure=tstore_structure,
             )
 
+            # TODO; Maybe create TS object and use TS.to_parquet() once implemented
             # Retrieve pyarrow Table
             table = df_ts.to_arrow()
 

diff --git a/tutorials/00_example_pandas.py b/tutorials/00_example_pandas.py
@@ -1,6 +1,6 @@
 #!/usr/bin/env python3
 """
-Created on Sun Apr  7 21:10:05 2024
+Created on Sun Apr  7 21:10:05 2024.
 
 @author: ghiggi
 """