DM-56333: DP2 NB: 201_17 tutorial on the visit_summary table by jrob93 · Pull Request #222 · lsst/tutorial-notebooks

jrob93 · 2026-10-09T11:49:52Z

First draft of the visit_summary butler only table tutorial. Based primarily on the VisitDetector tutorial due to overlapping columns.

Also includes snippets from 204.3. Astrometric Calibration and 205.2. PSF for visits because these tutorials use visit_summary as a workaround for visit_images not being available in EDP2.

Fro ticket https://rubinobs.atlassian.net/browse/DM-56333

review-notebook-app · 2026-10-09T11:49:58Z

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

garrethmartin · 2026-10-09T14:08:19Z

@@ -0,0 +1,1046 @@
+{


make sure flake8 runs clean. there are a few failures.

$ flake8-nb DP2/200_Data_products/201_Catalogs/201_17_Visit_summary_table.ipynb --max-line-length=99 --ignore=E133,E226,E228,E266,N802,N803,N806,N812,N813,N815,N816,W503
DP2/200_Data_products/201_Catalogs/201_17_Visit_summary_table.ipynb#In[ ]:3:1: E124 closing bracket does not match visual indentation
DP2/200_Data_products/201_Catalogs/201_17_Visit_summary_table.ipynb#In[ ]:4:1: E124 closing bracket does not match visual indentation
DP2/200_Data_products/201_Catalogs/201_17_Visit_summary_table.ipynb#In[ ]:3:27: E128 continuation line under-indented for visual indent
DP2/200_Data_products/201_Catalogs/201_17_Visit_summary_table.ipynb#In[ ]:3:100: E501 line too long (104 > 99 characters)
DP2/200_Data_products/201_Catalogs/201_17_Visit_summary_table.ipynb#In[ ]:4:27: E124 closing bracket does not match visual indentation
DP2/200_Data_products/201_Catalogs/201_17_Visit_summary_table.ipynb#In[ ]:2:6: E231 missing whitespace after ','
DP2/200_Data_products/201_Catalogs/201_17_Visit_summary_table.ipynb#In[ ]:1:53: E231 missing whitespace after ','
DP2/200_Data_products/201_Catalogs/201_17_Visit_summary_table.ipynb#In[ ]:5:62: E231 missing whitespace after ','
DP2/200_Data_products/201_Catalogs/201_17_Visit_summary_table.ipynb#In[ ]:23:14: E231 missing whitespace after ','
DP2/200_Data_products/201_Catalogs/201_17_Visit_summary_table.ipynb#In[ ]:23:16: E231 missing whitespace after ','
DP2/200_Data_products/201_Catalogs/201_17_Visit_summary_table.ipynb#In[ ]:23:18: E231 missing whitespace after ','
DP2/200_Data_products/201_Catalogs/201_17_Visit_summary_table.ipynb#In[ ]:23:29: E231 missing whitespace after ','
DP2/200_Data_products/201_Catalogs/201_17_Visit_summary_table.ipynb#In[ ]:23:56: E231 missing whitespace after ','

Reply via ReviewNB

Ah good catch, I completely forgot to run flake8!

I'm left with some W291 trailing whitespace flags that I'm not 100% sure how to resolve.

if you run flake8 with --select=W291 --show-source it should show you exactly where the issue is

Thanks for the tip! Done.

garrethmartin · 2026-10-09T14:08:19Z

@@ -0,0 +1,1046 @@
+{


maybe add some of the other more substantially used packages e.g. lsst.obs.lsst.LsstCam, lsst.images plus numpy etc

Reply via ReviewNB

Added lsst.images, lsst.obs.lsst

garrethmartin · 2026-10-09T14:08:19Z

@@ -0,0 +1,1046 @@
+{


per RTN-045, no need to mention tutorials in the same series

Reply via ReviewNB

Removed 201.11. I didn't realise this before so to be clear I think series is 201, so the other 200 level tutorials should be kept?

yes. i think so

garrethmartin · 2026-10-09T14:08:19Z

@@ -0,0 +1,1046 @@
+{


good to include assert statements for things like this e.g

assert butler is not None

Reply via ReviewNB

garrethmartin · 2026-10-09T14:08:19Z

@@ -0,0 +1,1046 @@
+{


is it worth briefly explaining what an ExposureCatalog/ExposureRecord actually is compared to e.g. a SourceCatalog?

Reply via ReviewNB

Added a bit more description and a link to https://pipelines.lsst.io/modules/lsst.afw.table/index.html

garrethmartin · 2026-10-09T14:08:19Z

@@ -0,0 +1,1046 @@
+{


2.1.4. -> 2.2.4.

Reply via ReviewNB

garrethmartin · 2026-10-09T14:08:19Z

@@ -0,0 +1,1046 @@
+{


"visits within 2 degrees" is this correct for OVERLAPS POINT? i think it only takes a position.

Reply via ReviewNB

garrethmartin · 2026-10-09T14:08:19Z

@@ -0,0 +1,1046 @@
+{


Line #3. search_radius = 2
not actually used

Reply via ReviewNB

garrethmartin · 2026-10-09T14:08:19Z

@@ -0,0 +1,1046 @@
+{


Line #2. for i,x in enumerate(visit_summary_tab.colnames):
avoid single character variable names

Reply via ReviewNB

garrethmartin · 2026-10-09T14:08:19Z

@@ -0,0 +1,1046 @@
+{


x and y axes and the colorbar should have units

and change single character variable names

Reply via ReviewNB

garrethmartin

please merge after addressing minor comments

move over from cst-dev

73898a5

garrethmartin self-assigned this Oct 9, 2026

garrethmartin reviewed Oct 9, 2026

View reviewed changes

garrethmartin approved these changes Oct 9, 2026

View reviewed changes

jrob93 added 5 commits October 12, 2026 14:01

flake8 fixes

51298d9

final comments

fb700b1

try fix some flake8

1510a19

flake8 fix

cb74480

Merge branch 'main' into tickets/DM-56333

f83377e

jrob93 merged commit 8a94aa6 into main Oct 13, 2026
2 checks passed

Conversation

jrob93 commented Oct 9, 2026

Uh oh!

review-notebook-app Bot commented Oct 9, 2026

Uh oh!

garrethmartin Oct 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

garrethmartin Oct 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

garrethmartin Oct 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

garrethmartin Oct 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

garrethmartin Oct 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

garrethmartin Oct 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

garrethmartin Oct 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

garrethmartin Oct 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

garrethmartin Oct 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

garrethmartin Oct 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

garrethmartin Oct 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

garrethmartin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

garrethmartin Oct 9, 2026 •

edited

Loading

garrethmartin Oct 13, 2026 •

edited

Loading

garrethmartin Oct 9, 2026 •

edited

Loading

garrethmartin Oct 9, 2026 •

edited

Loading

garrethmartin Oct 9, 2026 •

edited

Loading

garrethmartin Oct 9, 2026 •

edited

Loading

garrethmartin Oct 9, 2026 •

edited

Loading

garrethmartin Oct 9, 2026 •

edited

Loading

garrethmartin Oct 9, 2026 •

edited

Loading

garrethmartin Oct 9, 2026 •

edited

Loading

garrethmartin Oct 9, 2026 •

edited

Loading