DM-48591: Add multiprofit tasks to all pipelines #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taranu
force-pushed
the
tickets/DM-48591
branch
from
0c92cbc to
35a477b
Compare
TallJimbo
approved these changes
Feb 14, 2025
| @@ -76,19 +76,22 @@ tasks: | |||
| python: | | |||
| from lsst.pipe.tasks.diff_matched_tract_catalog import MatchedCatalogFluxesConfig | |||
| columns_flux = {} | |||
| fluxes_meas_psf = [] | |||
| fluxes_meas_other = [] | |||
| models_other = ("psf", "gaapOptimal", "kron", "sersic") | |||
There was a problem hiding this comment.
My understanding is that gaapOptimal is actually the least useful of the GaAP fluxes (the additional DOF needed to determine the aperture outweighs typically the fact that the aperture is a better match), and I'd like to remove it from the defaults if I remember and find the time. Is it included here because it's the most total-flux-like of them?
There was a problem hiding this comment.
I was hoping it had improved since being introduced ~3 years ago but in practice it seems to be really bad, so I supposed I'll replace it with whatever is deemed to be best (old messages suggest 1p0).
taranu
force-pushed
the
tickets/DM-48591
branch
2 times, most recently
from
814a5ab to
e5e8abe
Compare
Also remove now-unneeded analyze/merge tasks
This now needs to stay at the HSC default (grizy) so that multiprofit makes empty z & y flux columns.
taranu
force-pushed
the
tickets/DM-48591
branch
from
e5e8abe to
332d209
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.