DM-48748: Update ComCam Real/Bogus model #136
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebellm
force-pushed
the
tickets/DM-48748
branch
from
f885ddd to
a74d946
Compare
kfindeisen
reviewed
Feb 21, 2025
Comment on lines
17
to
19
| - type: dataset | ||
| dataset_type: pretrainedModelPackage | ||
| run: HSC/external | ||
| run: pretrained_models/tac_cnn_comcam_2025-02-18 |
There was a problem hiding this comment.
The substitution of HSC/external with pretrained_models looks a bit fishy. What's the story here? The original dataset path didn't have it as a subtring... 😕
There was a problem hiding this comment.
Good catch. ci_imsim handles the collections a bit differently and I didn't catch it.
ebellm
force-pushed
the
tickets/DM-48748
branch
from
a74d946 to
99fb6f7
Compare
kfindeisen
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.