Added support for custom DB port (default is also set)#563
Open
lospejos wants to merge 1 commit intolsfusion:masterfrom
Open
Added support for custom DB port (default is also set)#563lospejos wants to merge 1 commit intolsfusion:masterfrom
lospejos wants to merge 1 commit intolsfusion:masterfrom
Conversation
Contributor
|
Pretty good pull request. However the thing is that, as far as I understand, it is assumed that port is set as a part of host (for example localhost:3456). Maybe it makes sense sometimes to distinguish them, but so far it's not evident. However we'll think about merging this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for custom DB port (default is also set)