-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup of unused or outdated files #363
Open
HomesGH
wants to merge
9
commits into
master
Choose a base branch
from
deletefiles
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sed for validation
…using the ObjectGenerator in the xml config
…me outdated files
cniethammer
approved these changes
Dec 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the time to go over this - that's a really good bunch of cleanup!
FG-TUM
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are a lot of outdated or unused files which haven't been touched in ages. Those are probably not in use anymore or not even compilable. Therefore, we should delete them.
The following is deleted:
validation
folder (which was used by Jenkins in the past) since it is not used anymore. The input for the CI is now based on theexamples
.examples
folder:argon.sh
(just runs the argon example) andcomparison.xml
(which is a random config xml)--> Remove standalone-generators #364standalone generators
since this functionality is now implemented in ls1 using theObjectGenerator
in the xml config directlygrideval
since it is not documented and, therefore, probably not used anymoreMoved files:
checks
folderResolved Issues
How Has This Been Tested?
I had a look at the git history and tried to decide if the file/folder is still in use or will never be in the future.
Maybe I have deleted too much, so feel free to give some feedback or suggest further files.