Fix lint flow #86
Draft
Fix lint flow #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
machshev
force-pushed
the
fix_lint_flow
branch
3 times, most recently
from
95853d1 to
e3a9746
Compare
Collaborator
Author
|
It looks like the current fixes allow us to run the linting tools... however the reporting is stubbed out which means the results are not displayed in the terminal. |
It seems there sim flow specific assumptions in the deploy object base class, as well as the launcher base class. This issue is a lot broader than the regressions fixed in this commit. The code should be refactored to separate out the sim specific parts from the generic DVSim mechanism. Signed-off-by: James McCorrie <[email protected]>
machshev
force-pushed
the
fix_lint_flow
branch
from
e3a9746 to
2238d9b
Compare
Collaborator
Author
|
Reports partially restored. |
Improve the clarity on what is simulation flow specific and what is common. This makes way to fix the linting and formal flows, and creates more clarity on what is required to be implemented to add a new flow. Signed-off-by: James McCorrie <[email protected]>
Signed-off-by: James McCorrie <[email protected]>
machshev
force-pushed
the
fix_lint_flow
branch
from
d6ada35 to
017f5d1
Compare
rswarbrick
reviewed
Jan 9, 2026
| self.sim_cfg = sim_cfg | ||
| self.flow = sim_cfg.name | ||
|
|
||
| if not hasattr(self.sim_cfg, "variant"): |
Contributor
There was a problem hiding this comment.
Is variant used anywhere outside of deploy.py? If not, maybe a nicer hack would be to use things like this?
self._variant_suffix = f"_{self.sim_cfg.variant}" if self.sim_cfg.getattr("variant") else ""
That way, we don't touch the contents of the sim_cfg object.
| self.job_runtime.set(self.job_runtime_secs, "s") | ||
| try: | ||
| time, unit = plugin.get_job_runtime(log_text=lines) | ||
| self.job_runtime.set(time, unit) |
Contributor
There was a problem hiding this comment.
I'd probably suggest tweaking this code so that we set up a local time and unit variables on any of the three branches (including the exception below) and then only call self.job_runtime.set in one place?
| for link in self.links: | ||
| rm_path(self.links[link]) | ||
| pathlib.Path(self.links[link]).mkdir(parents=True) | ||
| Path(self.links[link]).mkdir(parents=True) |
Contributor
There was a problem hiding this comment.
Looks sensible. Since you're touching the line anyway, would it make sense to make a path variable from the string in this loop and use it explicitly for rm_path as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the regressions in the lint flow. All of the refactoring until now has been simulation focused, unfortunately this has resulted in some regressions in other flows such as linting.
The immediate goal is to restore the functionality of these other flows.