Merged
Conversation
AlexJones0
reviewed
Mar 6, 2026
Contributor
AlexJones0
left a comment
AlexJones0
left a comment
There was a problem hiding this comment.
Thanks @machshev, I'm happy for this to go in when my comment is addressed.
AlexJones0
approved these changes
Mar 6, 2026
Remove the hard coded OpenTitan git URL from the report. Instead use the git remote origin URL. This means that if you have cloned from a fork then the URL will be correct and link through to the commit in your fork. It doesn't matter if you cloned via SSH or HTTPS, the URL is correctly calculated. At the moment this assumes the URL is github, however others could be added at a later point. This commit also improves the testing of the git utils bringing coverage up to 100% for this module. Signed-off-by: James McCorrie <james.mccorrie@lowrisc.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Derive the HTML report git repo URL from
git remote get_url origin.