Skip to content

fix: patch for postHook without condition #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2025
Merged

fix: patch for postHook without condition #736

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/kubernetes/src/services/kuberunner.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ class KubeRunnerTest extends WebdaTest {
let runner = new KubeRunner(this.webda, "runner", { jobImage: "webda.io/runner" });
runner.resolve();
const kube = stub(runner.client, "create").returns(Promise.resolve({
spec: true,
metadata: "fake",
apiVersion: "1.0",
kind: "Job"
Expand Down
5 changes: 2 additions & 3 deletions packages/kubernetes/src/services/kuberunner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ export class KubeRunnerParameters extends RunnerParameters implements Kubernetes
/**
* Type of action returned by LocalRunner
*/
export interface KubeJob {}
export interface KubeJob extends k8s.V1Job {}

/**
* Run a Job locally on the server by spawning a child process
Expand Down Expand Up @@ -100,8 +100,7 @@ export default class KubeRunner<T extends KubeRunnerParameters = KubeRunnerParam
}
}
// Launch the resource now
const result = await this.client.create(resources);
return { metadata: result.body.metadata, apiVersion: result.body.apiVersion, kind: result.body.kind };
return await this.client.create(resources);
}

/**
Expand Down
Loading