Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds upload of release builds to S3 #17

Merged
merged 5 commits into from
Feb 12, 2025

Conversation

SuperManifolds
Copy link

No description provided.

@SuperManifolds SuperManifolds self-assigned this Feb 5, 2025
Copy link

@lgfa29 lgfa29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, but there are some comments from Architect the apply here as well.

Copy link

@lgfa29 lgfa29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why CI is failing, but it doesn't seem related to this change.

@pojntfx any ideas of what could be the problem?

@pojntfx pojntfx merged commit 3150ded into main-live-migration-pvm Feb 12, 2025
8 checks passed
@pojntfx pojntfx deleted the alex/s3-artifact-upload branch February 12, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants