feat: support non-root baseurl#2051
Draft
achrinza wants to merge 3 commits into
Draft
Conversation
This moves away from the compatibility setup which simulates Pages Legacy Worker workflow. This simplifies the setup, since the compat layer still converges to the same deployment strategy. Furthermore, we can remove dependency on the external GH Action with long-lived SSH credentials closes: #2048 Signed-off-by: Rifa Achrinza <25147899+achrinza@users.noreply.github.com>
see: loopbackio/security#26 Signed-off-by: Rifa Achrinza <25147899+achrinza@users.noreply.github.com>
This adds support for hosting on a nont-root sub-path (with `--baseurl` flag), such as when deploying on a GitHub fork Signed-off-by: Rifa Achrinza <25147899+achrinza@users.noreply.github.com>
achrinza
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This depends on (and branches from) #2049 for a newer version of Jekyll due to some behaviour differences in resolving
site.url.This adds support for hosting on a nont-root sub-path (with
--baseurlflag), such as when deploying on a GitHub fork.Comparison
Before:
After:
