fix(cli): invalid package.plain.json.ejs template #7416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generating a project (`lb4 app`) without enabling the `loopbackBuild` feature produces an invalid `package.json` with the following errors: - duplicated `main` field (should be `types` for the second one) - incorrect `types` path (should be `dist/index.d.ts`) - `services` feature not handled (missing dependency) - `repositories` flag not handled (always enabled) - duplicated `source-map-support` dependency Fixes for these issues are consistent with `package.json.ejs`. Signed-off-by: Simon Brunel <[email protected]>
raymondfeng
approved these changes
Apr 20, 2021
|
@simonbrunel, thanks for your contribution. Your PR has landed! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generating a project (
lb4 app) without enabling theloopbackBuildfeature produces an invalidpackage.jsonwith the following errors:mainfield (should betypesfor the second one) - introduced by refactor: remove hand-written index files #5440 (diff)typespath (should bedist/index.d.ts) - introduced by refactor: remove hand-written index files #5440 (diff)servicesfeature not handled (missing dependency) - missing in feat(service-proxy): add service mixin #1649repositoriesflag not handled (always enabled) - missing in feat(service-proxy): add service mixin #1649source-map-supportdependency - introduced by feat(cli): enable source map for npm start script #3228 (diff)Fixes for these issues are consistent with
package.json.ejs.Though, I'm wondering if I'm missing something because some of these bugs are 3 years old but I can't find any related bug report.
Checklist
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated