feat: improve ConsolidationEnhancer

[achrinza]

This PR should be bundled with other breaking changes.

Dynamic Disable
The enhancer can now be dynamically enabled & disabled after being bound.

This feature is intended to provide flexibility for LoopBack applications to have more "instant" configuration control during runtime without requiring a blocking rebind.

Static Class Members
Class members that do not require knowledge of the class state are now static.

Signed-off-by: Rifa Achrinza [email protected]

Checklist

• DCO (Developer Certificate of Origin) signed in all commits
• npm test passes on your machine
• New tests added or existing tests modified to cover all changes
• Code conforms with the style guide
• API Documentation in code was updated
• Documentation in /docs/site was updated
• Affected artifact templates in packages/cli were updated
• Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

[achrinza]

Should move this to property injection.

[marioestradarosa]

Are you modifying the _config object afterwards?

[achrinza]

ContextView would allow modification of the configuration after the ConsolidationEnhancer is initialised, which would give a better developer experience instead of having to re-bind the enhancer for those who need a more "dynamic" configuration.

[achrinza]

Suggested change

	private static patchRef(
	private static _patchRef(

[marioestradarosa]

Why changing the name? Do we have a convention to use _ for private declaration names?

[achrinza]

Ctrl + Shift + F on vscode shows that this naming convention is being used across several packages:

loopback-next/packages/context/src/binding.ts

Lines 360 to 377 in 1e3f628

	private _scope?: BindingScope;
	/**
	* Scope of the binding to control how the value is cached/shared
	*/
	public get scope(): BindingScope {
	// Default to TRANSIENT if not set
	return this._scope ?? BindingScope.TRANSIENT;
	}
	/**
	* Type of the binding value getter
	*/
	public get type(): BindingType | undefined {
	return this._source?.type;
	}
	private _cache: WeakMap<Context, ValueOrPromise<T>>;
	private _getValue?: ValueFactory<T>;

loopback-next/packages/core/src/application.ts

Lines 72 to 81 in 1e3f628

	private _isShuttingDown = false;
	private _shutdownOptions: ShutdownOptions;
	private _signalListener: (signal: string) => Promise<void>;
	private _initialized = false;
	/**
	* State of the application
	*/
	private _state = 'created';

loopback-next/packages/http-server/src/http-server.ts

Lines 89 to 94 in 1e3f628

	private _listening = false;
	private _protocol: HttpProtocol;
	private _address: string | AddressInfo;
	private requestListener: RequestListener;
	readonly server: http.Server | https.Server;
	private _stoppable: stoppable.StoppableServer;