chore: upgrade to TypeScript 3.5 #2996
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raymondfeng
requested review from
b-admike,
bajtos,
hacksparrow,
marioestradarosa and
nabdelgadir
as code owners
bajtos
approved these changes
May 30, 2019
| @@ -98,7 +101,7 @@ describe('TodoController', () => { | |||
|
|
|||
| describe('patch()', () => { | |||
| it('returns a number of todos updated', async () => { | |||
| patch.resolves([aChangedTodo].length); | |||
| patch.resolves({count: [aChangedTodo].length}); | |||
There was a problem hiding this comment.
Nice! IIUC, the stricter type checks are detecting programming errors we were not aware of 👍
packages/boot/src/__tests__/unit/booters/datasource.booter.unit.ts
Outdated
Show resolved
Hide resolved
| @@ -100,7 +100,7 @@ describe('TodoController', () => { | |||
|
|
|||
| it('uses the provided filter', async () => { | |||
| const find = todoRepo.stubs.find; | |||
| const filter: Filter = {where: {isCompleted: false}}; | |||
| const filter: Filter<Todo> = {where: {isComplete: false}}; | |||
1 task
|
Fixed the problems in d92f661 |
|
Rebased on top of the latest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to TypeScript 3.5
I have to address a few breaking changes:
unknowninstead of{}now.Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈